565792 - Drop bogus comment in navigator.js

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Justin Wood (:Callek)]

From IRC Chat:

<KaiRo> Callek: any idea what http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#2618 is about?
<Callek> KaiRo: top of my head, no; probably best to see where that was added in, or poke Ratty
<KaiRo> Callek: well, I'm in the middle of work, but just stumbled over this
* Callek is skimming stuff anyway though
<Callek> KaiRo: looks like if the urlbar is customized off, and then back on, on a feed page we don't update feed discovery, though Firefox does
<Callek> KaiRo: Firefox calls http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#4127 from http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#3371
<KaiRo> Callek: ah, we probably should file a bug on that, then - could you?

Quoted line that Robert asked me about was "// XXXRatty: Remember to update Feedhandler once we get one."

Ratty, do you have time to do this up?

Comment 1

[Philip Chee]

Need a few days to get a build environment on my new notebook.

Comment 2

[Philip Chee]

> <Callek> KaiRo: looks like if the urlbar is customized off, and then back on,
> on a feed page we don't update feed discovery, though Firefox does

Is there an actual problem? Unlike Firefox, our toolbar customization doesn't remove the elements from the DOM when moved into the palette so the urlbar feed button is always updated. So I guess all I need to do in this bug is to remove the useless comment.

Comment 3

[Robert Kaiser]

What about if someone might have customized away the URLbar (not sure why someone would, but it's possible) and only brings it in with it the first time since the window loaded? Do we correctly update the feed (or Larry) icons?

I specifically brought it up with Callek (you were asleep) because I wasn't sure if it held any value any more and I stumbled over it when working on places bookmarks (there's something on the personal bookmarks toolbar right in the vicinity of that comment).

Comment 4

[Philip Chee]

> What about if someone might have customized away the URLbar (not sure why
> someone would, but it's possible) and only brings it in with it the first time
> since the window loaded? Do we correctly update the feed (or Larry) icons?

I just tried this scenario. The feed button in the URLbar is correct as soon as I drop it on a toolbar. As I said if you customize the urlbar away, it's hidden but (unlike Firefox) not removed from the DOM so it continues to be updated even when it is in the toolbarpalette.

Comment 5

[Justin Wood (:Callek)]

Ratty,

Assuming your testing indicates this comment is really irrelevant, rs+=me to remove it for whoever wants to drop it.

Comment 6

[Philip Chee]

Attachment: Remove comment rs=Callek

> Assuming your testing indicates this comment is really irrelevant, rs+=me to
> remove it for whoever wants to drop it.
OK. Thanks.

Comment 7

[Philip Chee]

Checked-in to comm-central
http://hg.mozilla.org/comm-central/rev/a36490a5947f