Closed
Bug 566031
Opened 14 years ago
Closed 14 years ago
Switch "name" to be the default for tabs (to match windows and the world)
Categories
(Camino Graveyard :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
Details
Attachments
(1 file)
1.61 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
In bug 520514 comment 0, I suggested that we might want to switch the exposed property for tab titles from our (and OW's) "title" to the standard "name". Today Ilya pointed me to some bizarre gymnastics Adium is doing (backwards!) to try and support getting tab titles: http://trac.adium.im/ticket/13559 For 2.1, we should go ahead and make the switch to make "name" be the property exposed in the dictionary, so that we match what's exposed for windows and the rest of the world. Also, "title" works for browser windows, but not for windows, even though it compiles for windows in Script Editor. (I have no clue where it's coming from for browser windows, though; it's not defined for browser window itself, and it's certainly not inheriting it from window!) I think we can make "title" work for plain-old windows by adding a hidden property to the Core Suite's window class, which would make us consistent across the board: exposed "name" for window, browser window (which inherits from window), and tab, and hidden "title" for all three, too.
Assignee | ||
Comment 1•14 years ago
|
||
So, "title" is coming in all the way up at 'application' (i.e., "title of application" compiles, where it shouldn't); I think it's just a bug all-around (and an accident that it works at all for browser windows), and we shouldn't try to fake-support it in 'window'. I still have no idea *where* it's entering our dictionary from, though.
Status: NEW → ASSIGNED
Summary: Switch "name" to be the default for tabs (to match windows and the world) and add hidden support for "title" on windows → Switch "name" to be the default for tabs (to match windows and the world)
Assignee | ||
Comment 2•14 years ago
|
||
The old patches police raided my tree today. This just switches "name" to be the exposed property, just like the rest of the world (except OmniWeb) uses, and moves our non-standard "title" to be hidden, so that people looking at the dictionary won't use it any more.
Attachment #451216 -
Flags: superreview?(stuart.morgan+bugzilla)
Comment 3•14 years ago
|
||
Comment on attachment 451216 [details] [diff] [review] Switches name to be the exposed property for tabs, and title to be the hidden property sr=smorgan
Attachment #451216 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/camino/rev/8bc0877e8c6c and cvs trunk.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•14 years ago
|
||
http://wiki.caminobrowser.org/Development:Camino_AppleScript_Guide#New_in_Camino_2.1
You need to log in
before you can comment on or make changes to this bug.
Description
•