566051 - test.makeSandboxedLoader() should accept a 'moduleOverrides' option

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

For the purpose of mocking/faking-out module dependencies in unit tests, it should be possible to pass-in a mapping from module names to exports as a 'moduleOverrides' option to text.makeSandboxedLoader().

Comment 1

[Atul Varma [:atul]]

Attachment: first attempt at a patch

Comment 2

[Atul Varma [:atul]]

I'm not super happy with this patch, though we can make it nicer later; we really ought to make it easier in general to provide module overrides, since the cuddlefish module does this itself, and we'd really like to do dependency injection via 'require' for other things.

Comment 3

[Nickolay_Ponomarev]

While you're at it, please document makeSandboxedLoader()

http://hg.mozilla.org/labs/jetpack-sdk/file/tip/packages/jetpack-core/docs/unit-test.md

Comment 4

[Atul Varma [:atul]]

Attachment: un-bitrotted patch

Comment 5

[Atul Varma [:atul]]

Pushed: http://hg.mozilla.org/labs/jetpack-sdk/rev/60bb95120304

Comment 6

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".