Don't initialize fslots on allocation.

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
RESOLVED WONTFIX
7 years ago
5 years ago

People

(Reporter: gal, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
This saves a bunch of branching and initializing effort during allocation. It will be even more critical if objects grow to 16 words.
(Reporter)

Updated

7 years ago
Blocks: 558451
(Reporter)

Comment 1

7 years ago
Created attachment 445505 [details] [diff] [review]
patch

Also, slots are now initialized to NULL, not VOID. Faster to memset.
Assignee: general → gal
(Reporter)

Updated

7 years ago
Blocks: 571726
(Reporter)

Updated

7 years ago
Assignee: gal → paul.biggar
No longer blocks: 571726
(Reporter)

Comment 2

7 years ago
This patch is too broadly scoped and should be split up. Will discuss with paul.
(Reporter)

Updated

7 years ago
Summary: Clear objects during GC, don't initialize fslots on allocation. → Don't initialize fslots on allocation.
(Reporter)

Updated

7 years ago
Blocks: 571726
No longer blocks: 558451
Depends on: 558451

Updated

6 years ago
Assignee: paul.biggar → general

Comment 3

5 years ago
At this point, is this a WONTFIX?
Yeah.  The slots code has been overhauled massively.  Wouldn't surprise me if this was already done.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.