566081 - Inspect doesn't work inside iframes

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[(no longer active)]

STR:

1. Go to gmail.
2. Tools->Inspect.
3. Move the mouse over the window.

The entire content area is highlighted, and nothing else happens.  Esc/Enter do not work.  Clicking anywhere doesn't have any effect.  The inspector panel cannot be interacted with.  The only way to get your browser back is to switch tabs or Tools->Inspect again.

Comment 1

[Rob Campbell [:rc] (:robcee)]

I changed the dynamic inspection mechanism later in the review process and haven't had a chance to fix it to work properly with subdocuments. Gmail is a lot of iframes and the highlighter won't descend into them yet.

I'm going to modify the subject of this bug to reflect that. Thanks!

Comment 2

[Mihai Sucan [:msucan]]

Attachment: fix + test code

This is the patch that fixes the bug. The patch includes test code as well.

Please let me know if the patch needs any adjustments. It should apply cleanly on mozilla-central default branch.

I would also ask for nomination as a blocker for this bug, so we can get this checked into Firefox 4 betas.

Thanks!

Comment 3

[Rob Campbell [:rc] (:robcee)]

945  elementFromPoint: function IUI_elementFromPoint(aDocument, aX, aY)
946  {
947    var node = aDocument.elementFromPoint(aX, aY);

use let instead of var here.

Otherwise I think this looks great. Nice-looking test too.

Comment 4

[Mihai Sucan [:msucan]]

Attachment: [checked-in] updated fix + test code

Updated patch, as requested.

Thanks for your feedback+!

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 460536 [details] [diff] [review]
[checked-in] updated fix + test code

http://hg.mozilla.org/mozilla-central/rev/bd9d89e48566