566110 - [k] Form validation and error messages for forums forms

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Like a good (read: masochistic) tester, I pasted the US Constitution (HTML, though, [1]) into the "Title" field on http://support-stage-new.mozilla.com/en-US/forums/test-forum/new, and got:

"YOU SCREWED UP" (thanks! :)

[1] http://www.earlyamerica.com/earlyamerica/freedom/constitution/text.html

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

So that's just one case; you can do "space, space" ".,.", etc. with those fields, and it'll return that error.  We should be more specific about the minimum-post requirements, and highlight fields, etc. (might be a dupe, or already mentioned somewhere).

Comment 2

[James Socol [:jsocol, :james]]

(In reply to comment #1)
> So that's just one case; you can do "space, space" ".,.", etc. with those
> fields, and it'll return that error.  We should be more specific about the
> minimum-post requirements, and highlight fields, etc. (might be a dupe, or
> already mentioned somewhere).

When you're doing this, are you putting content in the main text area?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
> (In reply to comment #1)
> > So that's just one case; you can do "space, space" ".,.", etc. with those
> > fields, and it'll return that error.  We should be more specific about the
> > minimum-post requirements, and highlight fields, etc. (might be a dupe, or
> > already mentioned somewhere).
> 
> When you're doing this, are you putting content in the main text area?

Yes, just a single space "space, space" == space in the title, space in the body; guessing "YOU SCREWED UP" is just placeholder text for error handling?

Comment 4

[Paul Craciunoiu [:paulc]]

(In reply to comment #3)
> 
> Yes, just a single space "space, space" == space in the title, space in the
> body; guessing "YOU SCREWED UP" is just placeholder text for error handling?
Yep. Now you shouldn't be getting "YOU SCREWED UP" anymore, but instead a form with error messages.


http://github.com/jsocol/kitsune/commit/c8e175c270dd0505fb1a60e3ef46c8c58afe93a3

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.  Chowse could maybe weigh in on a non-nerdy error message (for which I'd file a spinoff bug).

Comment 7

[Chris Howse [:chowse]]

(In reply to comment #6)
> Verified FIXED.  Chowse could maybe weigh in on a non-nerdy error message (for
> which I'd file a spinoff bug).

How about:

"Please keep the length of your message to 10,000 characters or less.
 It is currently 29,671 characters."

(If you can add the thousands separator, even better.)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, chowse: spun off bug 568411.