Closed Bug 566125 Opened 10 years ago Closed 10 years ago

"Invalid command: ${UpdateShortcutAppModelIDs}" when building uninstaller

Categories

(SeaMonkey :: Installer, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: jimm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Current Windows build processes give the following error when building the uninstaller:

Invalid command: ${UpdateShortcutAppModelIDs}
Error in macro UninstallOnInitCommon on macroline 53
Error in script "uninstaller.nsi" on line 130 -- aborting creation process

Looks like this is coming from http://hg.mozilla.org/mozilla-central/rev/a24884c8140a for bug 562753 or http://hg.mozilla.org/mozilla-central/rev/2074183c0d6c for bug 521141 (which are closely related and landed in the same push anyhow.
This should be easy to fix by adding

!insertmacro UpdateShortcutAppModelIDs

to the uninstaller.nsi script.  Let me see if I can work up a patch.
OS: Linux → Windows 7
jimm, thanks for looking into that.
If we fix the bustage by that, we'll still want a bug to actually port the other stuff (given that we want to support Win7 well), right?
Blocks: 566138
Blocks: 494138
Attached patch patch (obsolete) — Splinter Review
Assignee: installer → jmathies
Attachment #445558 - Flags: review?(robert.bugzilla)
Attached patch patchSplinter Review
Attachment #445558 - Attachment is obsolete: true
Attachment #445558 - Flags: review?(robert.bugzilla)
Comment on attachment 445561 [details] [diff] [review]
patch

There's no Vendor in Thunderbird's application.ini.
Attachment #445561 - Flags: review?(robert.bugzilla)
Attachment #445561 - Flags: review?(robert.bugzilla) → feedback+
Comment on attachment 445561 [details] [diff] [review]
patch

Jim, this looks fine but I'm not a SeaMonkey or Thunderbird peer so you will need to get someone that is to r+ it which is why I changed it feedback+
Comment on attachment 445561 [details] [diff] [review]
patch

r=me for the suite/ parts.
Attachment #445561 - Flags: review+
http://hg.mozilla.org/comm-central/rev/1d899bd49d9e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to comment #8)
> http://hg.mozilla.org/comm-central/rev/1d899bd49d9e

Well theoretically, my review was only for the suite/ parts and not for the mail/ parts, but I'm sure the Thunderbird team won't be sad that their builds got fixed with this checkin ;-)
Comment on attachment 445561 [details] [diff] [review]
patch

Assuming TB considers my "Build-Config" peer status as applying to [un]installer adding a r+ just for future-sake.

Reviewed after the fact.
Attachment #445561 - Flags: review+
You need to log in before you can comment on or make changes to this bug.