566143 - Eliminate Shape from ObjectOps API

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Andreas Gal :gal]

Its a hazard when objects change nativeness and without it we can also get rid of dropProperty if we play our cards right.

Comment 1

[Igor Bukanov]

gal, do you work on this? I would like to eliminate at least the drop method as the first step with the ultimate goal of avoiding recursive lookupProperty calls on non-native prototypes in js_LookupProperty and friends.

Comment 2

[Andreas Gal :gal]

We can buddy up on this. I am planning major surgery on this, but we can do it in steps. My goal was to eliminate lookupProperty/dropProperty/get+setAttributes and replace them with hasProperty/getPropertyDescriptor/setPropertyDescriptor (getting/setting via JSPropertyDescriptor). get/setPropertyDescriptor will do its own lookup. JSScopeProperty is no longer exposed. Basically we will mirror the level of abstraction of procies with a few mild modifications and simplifications (merging enumerate and enumerateOwn) for example. I am also trying to figure out whether to do the proto walk inside or outside the API. Both has merit. Proxies (and e4x) want to lookup along proto on their own (or in case of e4x skip to NULL and stop the lookup). I was thinking maybe I will return the proto to consult next, then the loop is outside the api, but the api can stop the lookup.

Comment 3

[David Mandelin [:dmandelin]]

No activity in a long time. Are we still doing this?

Comment 4

[Andreas Gal :gal]

Yeah, but not for FF4 and we found a way around this for swap.

Comment 5

[David Bruant]

It isn't clear to me whether this bug is still relevant. Is it?

Comment 6

[Terrence Cole [:terrence]]

(In reply to David Bruant from comment #5)
> It isn't clear to me whether this bug is still relevant. Is it?

NI?ing Jason.

Comment 7

[Jeff Walden [:Waldo]]

Barely relevant.  I think the right way to interpret this now is to s/JSProperty/js::Shape/, at which point the only remaining op is lookupProperty.  Once that operation dies, we can consider this bug fixed.

Looking now, it appears at a skim that lookupProperty and LookupProperty and friends are basically used only for scope lookups of a name.  I'm not sure how much work it would be to remove that, just yet, but certainly we're closer to it than we've ever been.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:sdetar, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Jan de Mooij [:jandem]]

lookupProperty now uses PropertyResult* instead of Shape.

We should get rid of lookupProperty at some point, but I don't think we should keep this bug open for that.