HTMLInputElement and HTMLButtonElement should implement formaction attribute which override HTMLFormElement action attribute

RESOLVED FIXED in mozilla2.0b5

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 1 bug, {dev-doc-complete, html5})

Trunk
mozilla2.0b5
dev-doc-complete, html5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking2.0 beta5+)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
If a form is submitted via a submit button and if the element has a formaccept attribute, it should override the form accept attribute.
(Assignee)

Comment 1

7 years ago
s/accept/action/ in the previous comment
Summary: HTMLInputElement and HTMLButtonElement should implement formaccept attribute which override HTMLFormElement accept attribute → HTMLInputElement and HTMLButtonElement should implement formaction attribute which override HTMLFormElement action attribute
(Assignee)

Comment 2

7 years ago
Created attachment 445667 [details] [diff] [review]
Tests v1
Attachment #445667 - Flags: review?(jonas)
(Assignee)

Comment 3

7 years ago
Created attachment 445668 [details] [diff] [review]
Patch v1
Attachment #445668 - Flags: review?(jonas)
Attachment #445668 - Flags: review?(jonas) → review+
Comment on attachment 445667 [details] [diff] [review]
Tests v1

You might want to also test simply calling .click() on the elements.
Attachment #445667 - Flags: review?(jonas) → review+
(Assignee)

Comment 5

7 years ago
Blocker request: we would like to have this HTML5 Forms feature for ff4.
blocking2.0: --- → ?
(Assignee)

Updated

7 years ago
Depends on: 566064
Keywords: dev-doc-needed
(Assignee)

Comment 6

7 years ago
Created attachment 467035 [details] [diff] [review]
Patch v2

r=sicking

This is adding a test with .click() and refreshing the patch.
Attachment #445667 - Attachment is obsolete: true
Attachment #445668 - Attachment is obsolete: true
Attachment #467035 - Flags: superreview?(Olli.Pettay)

Updated

7 years ago
Attachment #467035 - Flags: superreview?(Olli.Pettay) → superreview+
blocking2.0: ? → beta5+
(Assignee)

Comment 7

7 years ago
Pushed: http://hg.mozilla.org/mozilla-central/rev/80b450a23c6b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5

Updated

7 years ago
Keywords: dev-doc-needed → dev-doc-complete

Updated

7 years ago
Depends on: 602512

Updated

7 years ago
No longer depends on: 602512
You need to log in before you can comment on or make changes to this bug.