566188 - MSAA nsAccessibleWrap::GetXPAccessibleFor should return nsAccessible*

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

try-server build - http://build.mozilla.org/tryserver-builds/[e-mail]-try-9b234caee6a8

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 445592 [details] [diff] [review]
patch

This try-server build works with JAWS, Window-Eyes and NVDA just fine.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 445592 [details] [diff] [review]
patch

>+
>+  nsCOMPtr<nsIAccessible> xpAccessibleResult;

Should that remain an nsIAccessible or should that be converted to an nsAccessible as well here?

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> (From update of attachment 445592 [details] [diff] [review])
> >+
> >+  nsCOMPtr<nsIAccessible> xpAccessibleResult;
> 
> Should that remain an nsIAccessible or should that be converted to an
> nsAccessible as well here?

We can do nothing with this now because it's used to store result from interface methods which deals with nsIAccessible. Probably we don't need anything, since the result will be queried to IAccessible any way since nsAccessible world doesn't know about nsAccessibleWrap.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 445592 [details] [diff] [review]
patch

>@@ -272,53 +265,50 @@ STDMETHODIMP nsDocAccessibleWrap::get_ac


> struct nsSearchAccessibleInCacheArg
> {
>-  nsRefPtr<nsAccessNode> mAccessNode;
>+  nsRefPtr<nsAccessible> mAccessible;
>   void *mUniqueID;
> };
> 
> static PLDHashOperator
> SearchAccessibleInCache(const void* aKey, nsDocAccessible* aDocAccessible,
>                         void* aUserArg)
> {
>   NS_ASSERTION(aDocAccessible,
>                "No doc accessible for the object in doc accessible cache!");
> 
>   if (aDocAccessible) {
>     nsSearchAccessibleInCacheArg* arg =
>       static_cast<nsSearchAccessibleInCacheArg*>(aUserArg);
>     nsAccessNode* accessNode =
>       aDocAccessible->GetCachedAccessNode(arg->mUniqueID);
>     if (accessNode) {
>-      arg->mAccessNode = accessNode;
>+      arg->mAccessible = do_QueryObject(accessNode);

Why the change from node to accessible? Doesn't it just add a do_QueryObject call?

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)

> Why the change from node to accessible? Doesn't it just add a do_QueryObject
> call?

It adds it here and then removes it there :) Since we expect nsAccessible from this method then I enclosed the query into it.

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 445592 [details] [diff] [review]
patch

fair enough, r=me thanks.

Comment 9

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/e9ea5ee4f010