Closed Bug 566241 Opened 14 years ago Closed 14 years ago

Video playback stops intermittently

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: cajbir, Assigned: cajbir)

References

Details

Attachments

(1 file, 1 obsolete file)

fix
881 bytes, patch
cajbir
: review+
Details | Diff | Splinter Review
Attached patch fix (obsolete) — — Splinter Review 
Playback of videos can stop at random times due to the audio and video decoding stopping in the method nsBuiltinDecoderStateMachine::AudioLoop. If we are skipping to the next keyframe we stop the audio from being queued. If we then run out of audio playback can stop.

This happens rarely with the existing code due to the settings of the audio threshold parameters. Tweaking these parameters makes the problem more apparent.
Attachment #445641 - Flags: review?(chris)
Blocks: 566245
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
Comment on attachment 445641 [details] [diff] [review]
fix

The condition you're removing doesn't fail on Windows, thanks for finding this!

Need to update the comment to reflect removing that condition.

Cheers!
Attachment #445641 - Flags: review?(chris) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Attached patch fix — — Splinter Review 
address review comment
Attachment #445641 - Attachment is obsolete: true
Attachment #445894 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/da003e6bbef0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: