566257 - FlightDeck addon should enable website to uninstall addon

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

It should be possible for FlightDeck to uninstall an addon using the FlightDeck addon, so it can install an addon when the user presses the "try in browser" button and uninstall it when the user is finished trying the addon (perhaps by pressing the same button again, if we make it a toggle button).

Comment 1

[Atul Varma [:atul]]

Fixed at the github repo: http://github.com/toolness/addons-builder-helper

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Two Mozilla FlightDeck helpers installed

Comment 3

[Piotr Zalewa [:zalun]]

I've tried to make it work, however

1. XPI build from github repository was not creating the window.mozFlightDeck object

2. The XPI loaded from https://secure.toolness.com/xpi/flightdeck.xpi was not giving a sane response to the isInstalled command

I was able to install both XPI's. The one from github had a new name, but both have the same version number (see attachment https://bugzilla.mozilla.org/attachment.cgi?id=450921).

To see the response from the isInstalled command it is enough to just test any addon on http://flightdeck.zalewa.info - it will display the response in console (undefined)

I don't know if it is FlightDeck's or the Add-on's fault.

Comment 4

[Piotr Zalewa [:zalun]]

The code which is sending isInstalled command: http://github.com/zalun/FlightDeck/blob/master/flightdeck/media/js/FlightDeck.js#L160

Comment 5

[Piotr Zalewa [:zalun]]

code is now here: http://github.com/zalun/FlightDeck/blob/master/flightdeck/media/js/FlightDeck.js#L82

Comment 6

[Atul Varma [:atul]]

Piotr, did you add http://flightdeck.zalewa.info and/or http://localhost to the data/addon-config.json file as mentioned in the README at http://github.com/toolness/addons-builder-helper ? In order to fix bug 552197 I had to add an explicit white-list of domains to add the window.mozFlightDeck object to.

I think the XPI loaded from https://secure.toolness.com/xpi/flightdeck.xpi may be super old, and thus obeying the older API instead of the new one. Sorry about that!

Comment 7

[Piotr Zalewa [:zalun]]

understood - will change the addon-config and try again

Comment 8

[Piotr Zalewa [:zalun]]

I changed the js a little - even with opened firebug console was for undefined.

System gives an "internalError" in the following line
http://github.com/zalun/addons-builder-helper/blob/master/lib/addons-builder-helper.js#L39

compiled xpi is available at http://piotr.zalewa.info/downloads/addons-builder-helper.xpi (or directly from the warning on http://flightdeck.zalewa.info/)

I was trying to install an xpi build from an add-on with comment only

Comment 9

[Atul Varma [:atul]]

(In reply to comment #8)
> I was trying to install an xpi build from an add-on with comment only

Does the source code for the addon have an exports.main() function defined? If it doesn't, then an error would happen on install b/c the bootstrapper assumes that it's defined--we need to give better feedback if it isn't, for sure.

Comment 10

[Atul Varma [:atul]]

Also, Jetpack currently has no integration with Firebug--if the addon calls console.log(), as per bug 570856 it's likely to appear in the JS Error Console for now, which can be seen by going to Tools->Error Console and then making sure "All" types of console messages are logged.

Comment 11

[Atul Varma [:atul]]

Piotr, I've filed bug 572181 and a patch for it, to allow defining an exports.main() to be optional instead of mandatory, which would make your comment-only addon not raise an error. Hopefully we can get this into 0.5, but we'll see!

Comment 12

[Piotr Zalewa [:zalun]]

As I said on #jetpack - Everything is working fine now. There is no bug as I claimed before, however there is a need to add a delay to the function which is checking if any Add-on is installed.