566263 - FlightDeck should use the standard process to generate XPI bundles

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Currently, FlightDeck uses a custom process for generating XPI bundles that uses the SDK but puts modules into non-standard locations.  FlightDeck should use the standard process built into the SDK for generating XPI bundles.

Piotr has proposed a new database architecture and XPI generation process for FlightDeck that would accomplish this goal:

http://github.com/zalun/FlightDeck/raw/master/Docs/Package%20Building%20System.pdf

Comment 1

[Piotr Zalewa [:zalun]]

I have a question regarding the name of the Package. We agreed it can change in time, hence the unique ID is used to authenticate the Package. Is there a need to keep a track of name changes? In other words - should name/fullName be an attribute of Package or PackageRevision (according to Figure 1 in the above doc)?

At the moment I've created the XPI Build system and tested it using "./script/test.sh jetpack" code may be taken from new_xpi_export branch on github. It's working well althought no attachment support yet

Comment 2

[Piotr Zalewa [:zalun]]

What is the name of directory for Package's attachment files? (.css, .png, etc)

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #1)
> I have a question regarding the name of the Package. We agreed it can change in
> time, hence the unique ID is used to authenticate the Package. Is there a need
> to keep a track of name changes? In other words - should name/fullName be an
> attribute of Package or PackageRevision (according to Figure 1 in the above
> doc)?

I don't think it's necessary to keep track of name changes.


(In reply to comment #2)
> What is the name of directory for Package's attachment files? (.css, .png, etc)

The name is "data", and it lives at the same level as package.json and the "lib" directory.

Comment 4

[Piotr Zalewa [:zalun]]

> the name of directory for Package's attachment files
It's not documented in the https://jetpack.mozillalabs.com/sdk/0.3/docs/#guide/package-spec
I assume it's hard-coded and may not be changed. Am I right?

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #4)
> > the name of directory for Package's attachment files
> It's not documented in the
> https://jetpack.mozillalabs.com/sdk/0.3/docs/#guide/package-spec

It's actually at the very bottom of that page, under the "Data Resources" header.


> I assume it's hard-coded and may not be changed. Am I right?

If you are using the SDK, you can always create and use arbitrary directories, although the API for accessing bundled resources is designed to look specifically in the data directory, and that's all FlightDeck needs to support.

Comment 6

[Piotr Zalewa [:zalun]]

> It's actually at the very bottom of that page
Indeed - I was looking for that in Manifest :)

That's fine - I just wasn't sure if I should place this info as an attribute of the addon

Comment 7

[Myk Melez [:myk] [@mykmelez]]

No, users shouldn't have to pick the name of this directory.  We shouldn't even tell them what it is.