566331 - Move JS code out of bug/edit.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Frédéric Buclin]

There is ~100 lines of JavaScript in bug/edit.html.tmpl. This code is pretty hard to read with all the english strings and TT code in it, and probably makes the life pretty difficult to localizers. This JS code should go somewhere into js/*.js, and relevant data passed to it (strings + bug data). Probably not an easy task.

Comment 1

[Frédéric Buclin]

Thanks to bug 653634, most of the JS functions defined in this template are gone. This leaves us with adjustRemainingTime() and updateRemainingTime() which could be moved into js/field.js, which is already loaded.

Comment 2

[Ishitva Goel]

Attachment: patch13d.diff

This patch removes the JS functions adjustRemainingTime() and updateRemainingTime() from bug/edit.html.tmpl and places them into js/field.js .
Also the variable name " fRemainingTime " is now changed to " bz_remaining_time " .

Comment 3

[Frédéric Buclin]

Comment on attachment 8385139 [details] [diff] [review]
patch13d.diff

>=== modified file 'js/field.js'

>+var bz_remaining_time;
>+function adjustRemainingTime(bz_remaining_time_arg) {
>+    bz_remaining_time = bz_remaining_time_arg;

This won't work. bz_remaining_time_arg is going to override bz_remaining_time. This function takes no argument.


>+    var new_time;
>+    // prevent negative values if work_time > remainingTime
>+    new_time =

You can merge these lines into one: var new_time = ...


>+}
>\ No newline at end of file

Please add a newline at the end of the file.



>=== modified file 'template/en/default/bug/edit.html.tmpl'

>+  adjustRemainingTime([% bug.remaining_time %]);
>+  updateRemainingTime();

That's not the right time to call these functions. They are called later, triggered by onchange. You must also define bz_remaining_time here.

Comment 4

[Ishitva Goel]

Attachment: patch13e.diff

The patch fixes the issues mentioned in the comment 3 .

Comment 5

[Frédéric Buclin]

Comment on attachment 8385245 [details] [diff] [review]
patch13e.diff

>=== modified file 'js/field.js'

>+    // prevent negative values if work_time > remainingTime

s/remainingTime/bz_remaining_time/


>+    document.changeform.remaining_time.value =
>+        Math.round(new_time * 100)/100;

Nit: this could be written on a single line.


Works fine. r=LpSolit with these fixes on checkin.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified js/field.js
modified template/en/default/bug/edit.html.tmpl
Committed revision 8955.