Closed Bug 566446 Opened 12 years ago Closed 8 years ago
Child are not handled by jsd
> Apparently the scripts created by appending script elements do not use the > normal paths Actually... they do. At least on the Gecko side they follow the same exact codepaths as any other script.
#0 JS_EvaluateUCScriptForPrincipals @ lineno=0 #1 nsJSContext::EvaluateString @ aLineNo=0 #2 nsScriptLoader::EvaluateScript 756 rv = context->EvaluateString(aScript, 757 globalObject->GetScriptGlobal(stid), 758 mDocument->NodePrincipal(), url.get(), 759 aRequest->mLineNo, aRequest->mJSVersion, nsnull, 760 &isUndefined); aRequest->mLineNo = 0 Afaiu, there's some unimplemented contract where people are not supposed to give line number 0 to stuff if they want to be nice. If we're lucky, jorendorff has already covered this.
Assignee: nobody → jorendorff
Depends on: 332176
QA Contact: jsd → general
Well, there is no line number associated with the script. Any line number would be a lie. If jsd can't handle such scripts, that's jsd's problem, no.
QA Contact: general → jsd
If 0 is special, then maybe -1 would be an appropriate value for scripts that do not appear in a file?
never mind, no, -1 would not work. First because that is an unsigned and second because it is a base number to which other numbers would be added. Sorry for the noise.
rauld: this is manageable at either level. don't worry about it. There's a patch for this in the other bug.
The other bug seems to be https://bugzilla.mozilla.org/show_bug.cgi?id=417040 where people were aggreeing that calling jsd with a line number of zero was a bug.
Some of the Firebug user bug reports related to this bug: http://code.google.com/p/fbug/issues/list?q=label:jQueryScript It prevents certain scripts loaded by the popular jQuery framework from loading.
bug 566446 has another test case that I believe is this bug.
Since there may be a patch for this very important problem over on bug 332176, I am nominating this bug to be reviewed.
blocking2.0: --- → ?
I don't see us holding the release for this, but the other patch should get approved if it gets r+'d and looks reasonably safe.
blocking2.0: ? → .x
This should be [firebug-p1]. This has become the standard for async loading. Just about every "widget" JS added to webpages uses it (Google Analytics, and AdSense, for example). jQuery, Dojo, ExtJS4, etc. use it as well.
We can't debug jQuery or dojo on Firefox.
Test case on http://code.google.com/p/fbug/issues/detail?id=4348 works great on Web Inspector.
The test case works in JSD2. Tested with Firefox 30.0a1 (Nightly) + the built-in debugger / Firebug 1.13.a8 with JSD2 support. So I believe this issue can be finally closed. Sebastian
JSD was removed in bug 800200, so I close this one now. Sebastian
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.