566477 - Missing argument in a call to GCDebugMsg

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Ruchi Lohani]

Attachment: Fix

GCDebugMsg call inside ReportDeletedMemoryWrite() is missing an argument - the address of the object. This appears to be a merge issue.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 445836 [details] [diff] [review]
Fix

Looks consistent with other format string uses.  r+

Lars: back on Larceny I started always using "%08x" instead of "%x" because some platforms would include leading zeros and others would not if you only used "%x", and it was easier for me if I saw consistent output everywhere.  Does that issue arise for us for VMPI_sprintf and GCDebugMsg?  Or do we ensure that format string rendering is not platform-dependent?

Comment 2

[Lars T Hansen]

(In reply to comment #1)
> (From update of attachment 445836 [details] [diff] [review])
> Looks consistent with other format string uses.  r+
> 
> Lars: back on Larceny I started always using "%08x" instead of "%x" because
> some platforms would include leading zeros and others would not if you only
> used "%x", and it was easier for me if I saw consistent output everywhere. 
> Does that issue arise for us for VMPI_sprintf and GCDebugMsg?  Or do we ensure
> that format string rendering is not platform-dependent?

We haven't dealt with that, mostly because we're not relying on printf et al except for debugging.  But though the C spec says that %p shall have a leading 0x, the Microsoft libraries omit that, for example.  (Nevermind the NUL-termination and return value....)

Comment 3

[Lars T Hansen]

Ruchi, if you don't have permissions to check this in let me know and I can do it.

Comment 4

[Lars T Hansen]

tamarin-redux changeset:   4705:ca540098145c.

I did not land this in tamarin-redux-argo since it's targeted for 10.2 and is a problem only in DEBUG builds.