566603 - random "###!!! ASSERTION: couldn't get canvas size: 'Not Reached'" in lots of canvas tests

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

http://hg.mozilla.org/mozilla-central/rev/e11ef37d8108 caused a major regression in reftest assertion counts last night:  lots of tests are asserting that weren't before.  (This is something I'm planning to make turn the tree orange once new try lands, hopefully later this week.)

The fix looks trivial:  it's the result of an uninitialized rv.

Here's the obvious patch, untested (but will be tested soon).

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 445961 [details] [diff] [review]
patch

doh! sorry, that looks good

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/225b3ddf48ec