566605 - Download progress widget doesn't update its progress meter

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre (.NET CLR 3.5.30729) ID:20100517035949

If you install a locally saved XPI via D&D to the Addons Manager, the download progress widget will display 0% done when the installation dialog comes up. But at this stage it should display 100%. 

Steps:
1. Download a XPI file
2. Use D&D to install that extension

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That doesn't only happen for locally stored XPI's. Even for add-ons which get downloaded from websites the progress meter will not update. It only shows 0% and once the extension has been downloaded to right end gets a blue background. But the middle part stays gray.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Hm, that sounds like a regression - that used to work for downloaded extensions. Think it was always broken for local files though.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, I think it's a layering issue here. We simply do not re-draw the area in the middle of the button. Is that a theme or a widget issue? We should probably move it to the correct component then.

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> Well, I think it's a layering issue here. We simply do not re-draw the area in
> the middle of the button. Is that a theme or a widget issue? We should probably
> move it to the correct component then.

What makes you think that?

Comment 5

[Dave Townsend [:mossop]]

The problem here looks to be that the progress meter is only updated whenever an onDownloadProgress event is received. But for local XPI's and if you open the add-ons manager after the download is finished no onDownloadProgress event will ever be sent, the progress is already 100%. The constructor probably needs to default the progress bar appropriately in these cases.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, when you watch the installation you will see that the start and end cap have the progress animation but in-between it's not shown. Looks like that something is positioned above the progress meter (between both ends) with a non-transparent background.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have never really tried to reproduce this bug on Windows. As it turns out it works when installing add-ons from the Search pane. Only on OS X the progress bar isn't updated. Could this be a simply theme issue?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is OS X only. Works fine on Windows and Linux.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #8)
> This is OS X only. Works fine on Windows and Linux.

Ok, that makes more sense. 

Also, the issue described in comment 5 is really a separate bug.

Comment 10

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Progress meters on OSX normally use a custom binding with basically no content, allowing the OS to actually paint the progress. This switches it back.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 479184 [details] [diff] [review]
patch rev 1

(In reply to comment #10)
> Progress meters on OSX normally use a custom binding with basically no content,
> allowing the OS to actually paint the progress. This switches it back.

This was confusing... to clarify: this switches it back to the *non custom* binding that other OSes use.

We probably want a comment in there, explaining why this hack-foo is needed.

Comment 12

[Dave Townsend [:mossop]]

Fixed: http://hg.mozilla.org/mozilla-central/rev/1d9300a951b7

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101023 Firefox/4.0b8pre