566629 - XSLT uppercasing name() function in XHTML documents

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Wired Earp]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/533.4 (KHTML, like Gecko) Chrome/5.0.375.38 Safari/533.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4) Gecko/20100407 MozillaDeveloperPreview/3.7a4

XPath name() function returns uppercase nodenames in Gecko 1.9.3 alpha 4. XPath local-name() function preserves the declared case as expected.

Reproducible: Always

Steps to Reproduce:
1. Create document or element in XHTML namespace.
2. Write XSL stylesheet, making use of the name() function.
3. Using JS API, transform the XML and view the output.
Actual Results:  
name() returns uppercase while local-name() preserves the case.

Expected Results:  
Both functions preserve nodename casing as declared in markup.

Check out the attachment, transforming live on stage to demonstrate the bug.

Comment 1

[Wired Earp]

Attachment: Testcase XHTML

Comment 2

[Boris Zbarsky [:bzbarsky]]

You're creating an HTML (not XHTML) document and passing that in to the XSLT transform.  In HTML documents, node names are uppercase (and this is required by the HTML5 spec) while localNames are in the original case.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Er, maybe not quite.  Let me look a bit more.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Nevermind comment 2.  Digging more.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We only do this on HTML elements. HTML element names are case insensitive in the markup, so it doesn't make sense to maintain the casing used in the markup. No DOM implementation does this.

We instead let the name() function return the same value as .nodeName, which in many cases is upper cased for HTML elements.

Comment 6

[Boris Zbarsky [:bzbarsky]]

OK, so this is sort of a regression from bug 488249 and the HTML namespace changes.

In txXPathNodeUtils::getNodeName we should presumably be checking for an HTML document, right?  And in localName we should nix the check altogether, since it never passes (IsHTML() implies namespace is not none).

Comment 7

[Boris Zbarsky [:bzbarsky]]

Note that the key is that we're NOT calling GetNodeName on the node here, but reimplementing it ourselves in the xslt treewalker.  And doing it wrong.

Comment 8

[Wired Earp]

To make things worse, the mentioned uppercasing of HTML nodeNames has been changed for the XSLT implementation according to ttps://developer.mozilla.org/en/Updating_extensions_for_Firefox_3.6 - both XSLT functions are now claimed to return lowercase for ordinary HTML documents:

"The name and the local-name functions in XPath returns the name of HTML elements in lower case. Previously, in HTML documents, they returned it in upper case."

XSLT on XHTML documents now seems to partly implement a deprecated feature of HTML documents. Thanks for digging in.

Comment 9

[Johnny Stenback (:jst)]

Over to Jonas, this should be a trivial fix, and it is a regression, so blocking.

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Trivial fix, we just want to uppercase if it's a HTML element in a HTML document.

Comment 11

[Henri Sivonen (:hsivonen)]

Is uppercasing in HTML documents required for compat? That is, why would we upper-case at all?

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

To be consistent with how the DOM works. It's not pretty, but I'd prefer to be consistent. And people should generally use local-name() anyway.

Comment 13

[Henri Sivonen (:hsivonen)]

Comment on attachment 481159 [details] [diff] [review]
Patch to fix

I wish we could get rid of the upper casing, but it's probably not worth the compat risk to try changing things too much. So, r=me.

Comment 14

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in

http://hg.mozilla.org/mozilla-central/rev/4d2eff8cc112