Closed Bug 566698 Opened 11 years ago Closed 11 years ago
Storei reject invalid param values
905 bytes, patch
|Details | Diff | Splinter Review|
Only 1,2,4,8 are allowed. http://www.khronos.org/opengles/sdk/docs/man/glPixelStorei.xml patch attached.
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Attachment #446039 - Flags: review?(vladimir)
oops, previous patch was wrong file. the gtk filechooser dialog is massively broken over here.
Attachment #446040 - Flags: review?(vladimir) → review+
This needs a test.
Also, it looks like the patch needs to be updated to use some ErrorInvalid* function.
Updated to return the right error. carried r+ from previous version.
aargh, typo, give me a minute...
(In reply to comment #3) > This needs a test. Yep, working on integrating the WebGL test suite this week -- there's a test in there for this. Marking all these things as in-testsuite? for verification once we get that in.
This time it should be good!
Attachment #448566 - Attachment is obsolete: true
If you are asking for review for this updated patch, probably not ready for checkin-needed.
Marking as duplicate as an updated patch is present in bug 571027.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 571027
You need to log in before you can comment on or make changes to this bug.