566698 - Make PixelStorei reject invalid param values

Status: RESOLVED DUPLICATE of bug 571027

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Only 1,2,4,8 are allowed.
http://www.khronos.org/opengles/sdk/docs/man/glPixelStorei.xml

patch attached.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Make PixelStorei reject invalid param values

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Make PixelStorei reject invalid param values

oops, previous patch was wrong file. the gtk filechooser dialog is massively broken over here.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This needs a test.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Also, it looks like the patch needs to be updated to use some ErrorInvalid* function.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Make PixelStorei reject invalid param values, updated

Updated to return the right error.

carried r+ from previous version.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

aargh, typo, give me a minute...

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> This needs a test.

Yep, working on integrating the WebGL test suite this week -- there's a test in there for this.  Marking all these things as in-testsuite? for verification once we get that in.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Make PixelStorei reject invalid param values, updated

This time it should be good!

Comment 9

[Justin Wood (:Callek)]

If you are asking for review for this updated patch, probably not ready for checkin-needed.

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

Marking as duplicate as an updated patch is present in bug 571027.