566716 - Search field of addon manager not work if opened in tab as about:addons

Status: RESOLVED DUPLICATE of bug 567333

(SeaMonkey :: General, defect)

Description

[Igor Velkov]

Attachment: text appears in status bar instead search box

Search (filter) field of addon manager work if it opens as separate window via menu, but not work if it open in tab by address about:addon entering into address bar. This actual for Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100518 Minefield/3.7a5pre ( .NET CLR 3.5.30729) too.

reproduce: 
open browser. 
enter "about:addons" into location bar
when addons manager loaded, click mouse into search field up right corner
type some text you want to lookup as addon name

see at status bar as browser work like in case of "search inside webpage by typing", no text appears in search bar

Comment 1

[Igor Velkov]

It's for 
Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100518 SeaMonkey/2.1a2pre

Comment 2

[Justin Wood (:Callek)]

This bug is in our side, I just reproduced and re-tested on Firefox side. I'm not sure what is up yet, but it "seems" like there may be a conflict with our find system.

Comment 3

[[e-mail]]

Attachment: Proposed patch

This bug also affects about:config; it's caused by a combination of factors. <xul:textbox> has a type attribute which the XBL anonymous <html:input> inherits; this allows you to write <textbox type="password">. However there were also some custom XUL types; originally one was called "timed" but that is now deprecated by "search". Although the HTML input inherited type="search" this was ignored and the type defaulted to "text". However <html:input type="search"> was recently added by bug 456229, so now the type really is "search".

It turns out that <input type="file"> never has focus so it's much easier just to look for the editor property (which is null for buttons).

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 446227 [details] [diff] [review]
Proposed patch

not a reviewer here, but based on some of the html5 tests and changes that have landed and I've seen this looks good.

Comment 5

[[e-mail]]

Pushed changeset b66512ef69bb to comm-central.

Comment 6

[Mounir Lamouri (:mounir)]

For information, you could have fix that with |mozIsTextField(false)|:

-    // Don't start a find if the focus is on a text, password or file field.
-    if (element instanceof Components.interfaces.nsIDOMHTMLInputElement &&
-        element.type in {text: true, password: true, file: true})
+    // Don't start a find if the focus is on a text field or file field.
+    if (element instanceof Components.interfaces.nsIDOMHTMLInputElement &&
+        (element.type == 'file' || element.mozIsTextField(false)))

Comment 7

[[e-mail]]

(In reply to comment #6)
> For information, you could have fix that with |mozIsTextField(false)|:
We actually need to use this in several places. I'll file a new bug.

Comment 8

[[e-mail]]

As per bug 567333, which has a better fix for this bug, this patch was superseded and backed out in changeset 7cba8dffcd68.