566773 - indirect eval calls js_GetCallObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

/*
     * If the caller is a lightweight function and doesn't have a variables
     * object, then we need to provide one for the compiler to stick any
     * declared (var) variables into.
     */
   if (caller->fun && !caller->callobj && !js_GetCallObject(cx, caller))
        return JS_FALSE;

Comment 1

[Brendan Eich [:brendan]]

We should get this fixed fast, avoid confusion and potential future bugs. Blake?

/be

Comment 2

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

I'll patch this tomorrow. We should be able to assert that there is already a call object, I think, because the only way to generate JSOP_EVAL is "eval()", which makes the function heavyweight.

Comment 3

[Brendan Eich [:brendan]]

The paragraph cited in comment 0 runs for indirect as well as direct evals, so I don't see how we can assert, unless you meant JS_ASSERT_IF(!indirectCall, ...).

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Attachment: Fix

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/8bc3bb17cb43