566849 - Toolkit's view source relies on browser.xul

Status: RESOLVED INVALID

(Toolkit :: View Source, defect)

Description

[Asaf Romano (gone)]

While he was reviewing my patch for bug 566736, Gavin found this code in toolkit's viewsource:

392     var browser = document.getElementById("ppBrowser");
393     if (!browser) {
394       browser = document.createElement("browser");
395       browser.setAttribute("id", "ppBrowser");
396       browser.setAttribute("flex", "1");
397       document.getElementById("appcontent").
398         insertBefore(browser, document.getElementById("FindToolbar"));

That's bad for a couple of reason:
 * FindToolbar isn't a child of appcontent
 * It creates a dependency on browser.xul structure.

How does SeaMonkey handle it?

Comment 1

[Dão Gottwald [:dao]]

That code refers to viewSource.xul, not browser.xul.

Comment 2

[Asaf Romano (gone)]

Oh, then me and Gavin are both confused.