Closed Bug 566849 Opened 14 years ago Closed 14 years ago

Toolkit's view source relies on browser.xul

Categories

(Toolkit :: View Source, defect)

Product:
Toolkit
Component:
View Source
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: asaf, Unassigned)

References

Details

(Keywords: regression) 

While he was reviewing my patch for bug 566736, Gavin found this code in toolkit's viewsource:

392     var browser = document.getElementById("ppBrowser");
393     if (!browser) {
394       browser = document.createElement("browser");
395       browser.setAttribute("id", "ppBrowser");
396       browser.setAttribute("flex", "1");
397       document.getElementById("appcontent").
398         insertBefore(browser, document.getElementById("FindToolbar"));

That's bad for a couple of reason:
 * FindToolbar isn't a child of appcontent
 * It creates a dependency on browser.xul structure.

How does SeaMonkey handle it?
That code refers to viewSource.xul, not browser.xul.
Oh, then me and Gavin are both confused.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.