Please remove dead code interface: nsIBaseStream

RESOLVED FIXED in mozilla8

Status

()

Core
XPCOM
--
trivial
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: WeirdAl, Assigned: dzbarsky)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 551639 [details] [diff] [review]
Patch
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #551639 - Flags: review?(khuey)
Does this compile?  It looks like nsScriptableInputStream::Close is used ...
(Assignee)

Comment 3

6 years ago
Created attachment 551642 [details] [diff] [review]
Patch
Attachment #551639 - Attachment is obsolete: true
Attachment #551642 - Flags: review?(khuey)
Attachment #551639 - Flags: review?(khuey)
(Assignee)

Comment 4

6 years ago
Created attachment 551644 [details] [diff] [review]
Patch that actually compiles

Gah, the code was lying.
Attachment #551642 - Attachment is obsolete: true
Attachment #551644 - Flags: review?(khuey)
Attachment #551642 - Flags: review?(khuey)
Comment on attachment 551644 [details] [diff] [review]
Patch that actually compiles

I'm not really a peer, but this is easy enough.

r=me
Attachment #551644 - Flags: review?(khuey) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 551854 [details] [diff] [review]
Patch r=khuey
Attachment #551644 - Attachment is obsolete: true
Attachment #551854 - Flags: checkin?
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/863ba598a27b
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/863ba598a27b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8

Updated

6 years ago
Attachment #551854 - Flags: checkin? → checkin+
You need to log in before you can comment on or make changes to this bug.