567056 - Rename AspectRatio to PixelAspectRatio in video backend files

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[cajbir (:cajbir)]

AspectRatio was renamed to PixelAspectRatio as part of a refactoring/cleanup of the media code when the webm decoder was written.

Comment 1

[cajbir (:cajbir)]

Attachment: fix

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 446453 [details] [diff] [review]
fix

   float aspectRatio = 0;
   // Set a default callback period for if we have no video data
   mCallbackPeriod = 1000 / AUDIO_FRAME_RATE;
   if (mTheoraState) {
     if (mTheoraState->Init()) {
       mCallbackPeriod = mTheoraState->mFrameDuration;
-      aspectRatio = mTheoraState->mAspectRatio;
+      aspectRatio = mTheoraState->mPixelAspectRatio;
       gfxIntSize sz(mTheoraState->mInfo.pic_width,
                     mTheoraState->mInfo.pic_height);
-      mDecoder->SetVideoData(sz, mTheoraState->mAspectRatio, nsnull);
+      mDecoder->SetVideoData(sz, mTheoraState->mPixelAspectRatio, nsnull);

We never use the aspectRatio variable so we can remove it.

Comment 3

[cajbir (:cajbir)]

Attachment: fix

Addresses review comment to remove local aspectRatio usage.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/229f7795d5d1