Closed Bug 567056 Opened 11 years ago Closed 11 years ago

Rename AspectRatio to PixelAspectRatio in video backend files

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: cajbir, Assigned: cajbir)

Details

Attachments

(1 file, 1 obsolete file)

AspectRatio was renamed to PixelAspectRatio as part of a refactoring/cleanup of the media code when the webm decoder was written.
Attached patch fix (obsolete) — Splinter Review
Attachment #446453 - Flags: review?(kinetik)
Comment on attachment 446453 [details] [diff] [review]
fix

   float aspectRatio = 0;
   // Set a default callback period for if we have no video data
   mCallbackPeriod = 1000 / AUDIO_FRAME_RATE;
   if (mTheoraState) {
     if (mTheoraState->Init()) {
       mCallbackPeriod = mTheoraState->mFrameDuration;
-      aspectRatio = mTheoraState->mAspectRatio;
+      aspectRatio = mTheoraState->mPixelAspectRatio;
       gfxIntSize sz(mTheoraState->mInfo.pic_width,
                     mTheoraState->mInfo.pic_height);
-      mDecoder->SetVideoData(sz, mTheoraState->mAspectRatio, nsnull);
+      mDecoder->SetVideoData(sz, mTheoraState->mPixelAspectRatio, nsnull);

We never use the aspectRatio variable so we can remove it.
Attachment #446453 - Flags: review?(kinetik) → review+
Attached patch fixSplinter Review
Addresses review comment to remove local aspectRatio usage.
Attachment #446453 - Attachment is obsolete: true
Attachment #446654 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/229f7795d5d1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.