Closed
Bug 567065
Opened 15 years ago
Closed 14 years ago
Try to create offscreen Xlib surface from existing visual if possible
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b2
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file, 1 obsolete file)
4.80 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Problem is so that gfxPlatformQt creating offscreen surface with
gfxXlibSurface(Display* dpy, XRenderPictFormat *format, const gfxIntSize& size);
And after that cairo return NULL visual because it is not trying to find visual and set it to xlib_surface structure...
http://mxr.mozilla.org/mozilla-central/source/gfx/cairo/cairo/src/cairo-xlib-surface.c#3196
I think we should try to find related visual, and call
new gfxXlibSurface(Display *dpy, Visual *visual, const gfxIntSize& size, int depth = 0);
Attachment #446463 -
Flags: review?(vladimir)
Comment 1•15 years ago
|
||
Assignee | ||
Comment 2•15 years ago
|
||
Assignee: nobody → romaxa
Attachment #446463 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #446745 -
Flags: review?(jmuizelaar)
Attachment #446463 -
Flags: review?(vladimir)
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 446745 [details] [diff] [review]
cairo patch, updated to trunk.
This patch seems to break plugins rendering
Attachment #446745 -
Flags: review?(jmuizelaar) → review-
Comment 4•15 years ago
|
||
(In reply to comment #3)
> This patch seems to break plugins rendering
Flash with GTK ports would need DRAW_SUPPORTS_NONDEFAULT_VISUAL to be removed:
http://hg.mozilla.org/mozilla-central/annotate/d7ba6aef21eb/layout/generic/nsObjectFrame.cpp#l5135
(I'm not clear on exactly which visuals Flash Player does support; it may only be ARGB visuals causing problems.)
I don't know why it would "break" Qt ports.
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 446745 [details] [diff] [review]
cairo patch, updated to trunk.
Yep, you right... removing non-default visual helps in this situation.
And this patch seems to work fine
Attachment #446745 -
Flags: review- → review?(jmuizelaar)
Comment 6•14 years ago
|
||
Oleg, can you try to upstream this patch? There are people on the cairo list that would be better at reviewing this then me.
Assignee | ||
Comment 7•14 years ago
|
||
Bug created:
https://bugs.freedesktop.org/show_bug.cgi?id=28492
Message posted to cairo mailing list.
Assignee | ||
Comment 8•14 years ago
|
||
Ok, patch already in cairo upstream ;)
http://cgit.freedesktop.org/cairo/commit/?id=55037bfb2454a671332d961e061c712ab5471580
Comment 9•14 years ago
|
||
Comment on attachment 446745 [details] [diff] [review]
cairo patch, updated to trunk.
Looks good. Make sure you add the patch to the cairo directory
Attachment #446745 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 10•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•14 years ago
|
||
due Gdk-CRITICAL **: gdk_x11_visual_get_xvisual
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276838409.1276840450.21437.gz&fulltext=1
REFTEST INFO | Loading a blank page
REFTEST TEST-START | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/540114-1.html
NPP_Destroy
NPP_Destroy
WARNING: gdk_x11_visual_get_xvisual: assertion `visual != NULL' failed: 'glib warning', file /builds/slave/mozilla-central-linux/build/toolkit/xre/nsSigHandlers.cpp, line 193
(firefox-bin:1997): Gdk-CRITICAL **: gdk_x11_visual_get_xvisual: assertion `visual != NULL' failed
WARNING: gdk_x11_colormap_get_xcolormap: assertion `GDK_IS_COLORMAP (colormap)' failed: 'glib warning', file /builds/slave/mozilla-central-linux/build/toolkit/xre/nsSigHandlers.cpp, line 193
(firefox-bin:1997): Gdk-CRITICAL **: gdk_x11_colormap_get_xcolormap: assertion `GDK_IS_COLORMAP (colormap)' failed
###!!! [Parent][RPCChannel] Error: Channel error: cannot send/recv
REFTEST TEST-UNEXPECTED-FAIL | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/540114-1.html | plugin should not crash item 1
REFTEST INFO | Loading a blank page
REFTEST TEST-START | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/570884.html
REFTEST TEST-PASS | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/570884.html | (LOAD ONLY)
REFTEST INFO | Loading a blank page
REFTEST TEST-START | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/parser/htmlparser/tests/crashtests/30885-1.html
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•14 years ago
|
||
I'm guessing that was caused by gfxPlatformGtk::CreateOffscreenSurface using a GdkPixmap with no colormap:
http://hg.mozilla.org/mozilla-central/annotate/5f3955a452ac/gfx/thebes/src/gfxPlatformGtk.cpp#l195
One option might be to put a sensible colormap on the surface.
Though simpler (and maybe better) would be to just let
gfxXlibSurface(Display*, XRenderPictFormat*, const gfxIntSize&)
create the pixmap.
(Now that the cairo surface has an associated visual, the GdkPixmap wrapper will get added if and only when it is needed.)
Comment 13•14 years ago
|
||
I filed bug 573319 on CreateOffscreenSurface.
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 14•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 15•14 years ago
|
||
reverted in http://hg.mozilla.org/mozilla-central/rev/200f9be1c8e5
due to svg crashtest fail: see bug 573319
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 16•14 years ago
|
||
Bug 574220 and bug 569775 probably need to be resolved before we can land this.
Comment 17•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3b2
You need to log in
before you can comment on or make changes to this bug.
Description
•