Closed Bug 567074 Opened 10 years ago Closed 10 years ago

Incorrect information in "Your tabs form last time" in about:home

Categories

(Firefox for Android Graveyard :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ahoza, Assigned: mfinkle)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0(X11;U;Linux armv7l; Nokia N900; en-US;rv:1.9.2.5pre) Gecko/20100519 Namoroka/3.6.5pre Fennec 1.1b2pre 

Information is not correct in "Your tabs form last time", if in the previous session, empty tabs were opened. 

Reproducible: Always

Steps to Reproduce:
1.Open Fennec.
2.Open 5 more tabs. (don't enter any information in Awesome bar)
3.In the last opened, enter google.com. (this should be the sixth tab)
4. Close Fennec and open it again.
  
Actual Results:  
"Your tabs form last time" contains the following text: "No tabs from last time"

Expected Results:  
"Your tabs form last time" should contain Google.
The current code in aboutHome.xhtml will only check the first 5 tabs from session restore. If those 5 tabs fail to meet the "show in list" criteria, the list would be empty.
For a FYI, what is the criteria?
Whiteboard: mobile-triage
Assignee: nobody → mark.finkle
Whiteboard: mobile-triage
Attached patch patch (obsolete) — Splinter Review
This patch adds a counter so we can track the number of "valid" tabs we add to the startpage.
Attachment #449274 - Flags: review?(mbrubeck)
Comment on attachment 449274 [details] [diff] [review]
patch

r+ but I'm curious why we have such a small limit at all.  Won't it be pretty common for users to have more than 5 tabs open?
Attachment #449274 - Flags: review?(mbrubeck) → review+
(In reply to comment #5)
> (From update of attachment 449274 [details] [diff] [review])
> r+ but I'm curious why we have such a small limit at all.  Won't it be pretty
> common for users to have more than 5 tabs open?

It was arbitrary. Just didn't want to fill the screen and push down other content.

We could make it a preference (hidden) or show all. Madhava?
I'd show all, I think. A limit on # of add-ons makes sense, because the user didn't ask for or create them, but that's not the case for tabs. In fact, I wouldn't be surprised if the tab you want from last time is one of the last few, which would be excluded here.
Attached patch patch 2Splinter Review
This patch shows all (no limit) pages from tab history, except about: pages
Attachment #449274 - Attachment is obsolete: true
Attachment #449337 - Flags: review?(mbrubeck)
Attachment #449337 - Flags: review?(mbrubeck) → review+
pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/00f83b41835b
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110922
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.