567173 - An add-on with an invalid id can be installed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Found while writing the tests for bug 546595.

I was able to install an add-on With an install.rdf as follows

<?xml version="1.0"?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
  xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:id>undefined</em:id>
    <em:version>2.0</em:version>
    <em:bootstrap>true</em:bootstrap>
    <em:name>test1</em:name>
    <em:description>Test Description</em:description>
    <em:targetApplication>
      <Description>
        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
        <em:minVersion>1.0</em:minVersion>
        <em:maxVersion>99.0</em:maxVersion>
      </Description>
    </em:targetApplication>
  </Description>
</RDF>

using
AddonManager.getInstallForFile(xpiFile, function(install) {
  install.install();
});

The following was displayed in the error console

Comment 1

[Dave Townsend [:mossop]]

Fixed by the patch in bug 570200

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a6pre) Gecko/20100611 Minefield/3.7a6pre