567292 - "ASSERTION: Ancestors of nodes with frames to be constructed lazily should have frames" with frameset, xbl

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Ancestors of nodes with frames to be constructed lazily should have frames: 'content->GetPrimaryFrame() || bogusPrimaryFrame || (content->GetFlattenedTreeParent() && content->GetFlattenedTreeParent()->GetPrimaryFrame() && content->GetFlattenedTreeParent()->GetPrimaryFrame()->IsLeaf())', file /Users/jruderman/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 6252

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

These assertions in this function are getting out of hand. Every time I say "ok, this time we'll just make them a little more complex, but after that we'd better think of a better plan."

In this case the anonymous children are nested deeper and so we need to deal with arbitrarily deeply nesting under leaf frames. To do this we keep track of the assert conditions in the loop and reset them if we hit a leaf frame and assert if they are still set after the loop is done.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 446649 [details] [diff] [review]
patch

r=me, but this is starting to get ridicuous.  I almost feel sorry I asked for those asserts... ;)

Comment 3

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/da3c328f89a8