567296 - Bugzilla::Bug should use VALIDATOR_DEPENDENCIES instead of UPDATE_VALIDATORS

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

Most or all of Bugzilla::Bug's run_create_validators can be replaced with the VALIDATOR_DEPENDENCIES system.

Comment 1

[Max Kanat-Alexander]

Attachment: Work In Progress

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Here we go!

Custom fields go into VALIDATOR_DEPENDENCIES because of the is_mandatory checks, so that fields are set in the proper order during set_all.

Comment 3

[David Lawrence [:dkl]]

SQL error when creating a new bug:

[Thu Jun 03 00:40:28 2010] [error] DBD::mysql::db do failed: Column 'component_id' cannot be null [for Statement "INSERT INTO bugs (priority, reporter, bug_file_loc, product_id, rep_platform, assigned_to, everconfirmed, qa_contact, short_desc, status_whiteboard, bug_severity, bug_status, delta_ts, version, deadline, estimated_time, component_id, target_milestone, alias, op_sys) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"] at /var/www/html/bugzilla/Bugzilla/Object.pm line 496\n\tBugzilla::Object::insert_create_data('Bugzilla::Bug', 'HASH(0x7f42405ac848)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 522\n\tBugzilla::Bug::create('Bugzilla::Bug', 'HASH(0x7f424228ee50)') called at /var/www/html/bugzilla/post_bug.cgi line 164\n\tModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_post_bug_2ecgi::handler('Apache2::RequestRec=SCALAR(0x7f42427c87f8)') called at /usr/lib64/perl5/ModPerl/RegistryCooker.pm line 204\n\teval {...} called at /usr/lib64/perl5/ModPerl/RegistryCooker.pm line 204\n\tModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x7f4243487900)') called at /usr/lib64/perl5/ModPerl/RegistryCooker.pm line 170\n\tModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x7f4243487900)') called at /usr/lib64/perl5/ModPerl/Registry.pm line 31\n\tModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x7f42427c87f8)') called at /var/www/html/bugzilla/mod_perl.pl line 115\n\tBugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x7f42427c87f8)') called at -e line 0\n\teval {...} called at -e line 0\n

The error is coming from:

+    my $component = delete $params->{component};
+    $params->{component_id} = $params->{component};

Should be:

+    my $component = delete $params->{component};
+    $params->{component_id} = $component->id;

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 446910 [details] [diff] [review]
v1

See comment 3

Comment 5

[Max Kanat-Alexander]

Attachment: v2

Ah, thanks! Here's a patch with that fixed.

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 449004 [details] [diff] [review]
v2

Code looks good and all my testing was successful. r=dkl

Comment 7

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7205.