567376 - Try server emails aren't showing the changeset

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

This is getting handled fine in the creation of the packages and the uploading to tryserver-builds but the email generation in status/generators.py is messing up the build properties of got_revision and who.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: sets who and revision in unittest packaged factory

this will also take care of https://bugzilla.mozilla.org/show_bug.cgi?id=550176

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: sets who and revision in unittest packaged factory initialSteps

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: sets who and revision in unittest packaged factory initialSteps with try/except

better handling of edge case where the change doesn't have info

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: sets who and revision in unittest packaged factory initialSteps with try/except

and without the additional return this time.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 446831 [details] [diff] [review]
sets who and revision in unittest packaged factory initialSteps with try/except

http://hg.mozilla.org/build/buildbotcustom/rev/01941b42d5bf

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed, try-master reconfiged, confirmed the properties are now set.  if emails arrive that do not have this corrected please re-open.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Just noticed that this is not working in the "everything else" builder, only in the mochitest builders.  So we're only halfway done on this. Will get to it first thing Monday.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

putting the setting of who and revision in initial steps sets this for all packaged builders now.