browser_461634.js test failing on latest trunk

RESOLVED FIXED

Status

SeaMonkey
Session Restore
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

(Blocks: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.07 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 446881 [details] [diff] [review]
fixed test

mochitest-browser-chrome failed:
make[1]: *** [mochitest-browser-chrome] Error 1

Running chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js...
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | Only one browser window should be open initially
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | Closed tab list has the expected length
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | The correct amout of tabs are to be forgotten - Got 0, expected 2
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | Everything is set up. - Got 0, expected 2
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | Invalid window for forgetClosedTab throws
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | Invalid tab for forgetClosedTab throws
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | Invalid tab for forgetClosedTab throws
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | The correct amout of tabs was removed
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | All tabs specifically forgotten were indeed removed
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | ... and tabs not specifically forgotten weren't. - Got 0, expected 2
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | Only one browser window should be open eventually
TEST-INFO | checking window state
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | before wait for focus -- loaded: complete active window: <no window active> focused window: <no window focused> desired window: ([object ChromeWindow]) chrome://navigator/content/navigator.xul child window: ([object XPCNativeWrapper [object Window]]) data:text/html,<body%20onload="setTimeout(function%20()%20{%20document.getElementById('target').focus();%20},%2010);"><input%20id='target'></body> docshell visible: true
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | must wait for focus
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | waitForEvent called <type:focus, target[object XPCNativeWrapper [object HTMLDocument]]> -- loaded: complete active window: ([object ChromeWindow]) chrome://navigator/content/navigator.xul focused window: ([object XPCNativeWrapper [object Window]]) data:text/html,<body%20onload="setTimeout(function%20()%20{%20document.getElementById('target').focus();%20},%2010);"><input%20id='target'></body> desired window: ([object ChromeWindow]) chrome://navigator/content/navigator.xul child window: ([object XPCNativeWrapper [object Window]]) data:text/html,<body%20onload="setTimeout(function%20()%20{%20document.getElementById('target').focus();%20},%2010);"><input%20id='target'></body> docshell visible: true
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_461634.js | maybe run tests <load:true, focus:true> -- loaded: complete active window: ([object ChromeWindow]) chrome://navigator/content/navigator.xul focused window: ([object XPCNativeWrapper [object Window]]) data:text/html,<body%20onload="setTimeout(function%20()%20{%20document.getElementById('target').focus();%20},%2010);"><input%20id='target'></body> desired window: ([object ChromeWindow]) chrome://navigator/content/navigator.xul child window: ([object XPCNativeWrapper [object Window]]) data:text/html,<body%20onload="setTimeout(function%20()%20{%20document.getElementById('target').focus();%20},%2010);"><input%20id='target'></body> docshell visible: true


I did something weird in this test, because of lack of proper undoCloseTab implementation, but now mostly can use Firefox version.
Attachment #446881 - Flags: review?(neil)

Comment 1

8 years ago
Comment on attachment 446881 [details] [diff] [review]
fixed test

>-     closedTabs = JSON.parse(ss.getClosedTabData(newWin));
>+    closedTabs = eval("(" + ss.getClosedTabData(newWin) + ")");
Why this change? (There may be others; a -w diff would help!)
(Assignee)

Comment 2

8 years ago
Created attachment 446952 [details] [diff] [review]
properly fixed test

Sorry, copypasted without thinking ...
Attachment #446881 - Attachment is obsolete: true
Attachment #446952 - Flags: review?(neil)
Attachment #446881 - Flags: review?(neil)

Comment 3

8 years ago
Comment on attachment 446952 [details] [diff] [review]
properly fixed test

>+    ss.setWindowState(newWin, JSON.stringify(test_state), true);
>+    
Nit: spaces on blank line.

This is a review by inspection only, I didn't try running the test.
Attachment #446952 - Flags: review?(neil) → review+
(Assignee)

Updated

8 years ago
Blocks: 452942
(Assignee)

Comment 4

8 years ago
Pushed: http://hg.mozilla.org/comm-central/rev/24fd84018f88
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.