Closed
Bug 567636
Opened 15 years ago
Closed 15 years ago
replace GetAccessibleInParentChain on GetContainerAccessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
|
20.11 KB,
patch
|
MarcoZ
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
1. GetAccessibleInParentChain is util method, it's wrong to keep in in nsIAccessibleDocument
2. GetAccessibleInParentChain returns document if the document node is passed, we don't rely on this behavior. So remove it since it's confusing (we skip the node when search an accessible until the node is document)
3. Make it return nsAccessible pointer to avoid excess query interfaces
4. Move GetAccessibleInParentChain to accessibility service where we keep util methods and rename it GetContainerAccessible
Attachment #446949 -
Flags: review?(marco.zehe)
Attachment #446949 -
Flags: review?(bolterbugz)
|
Assignee | |
Updated•15 years ago
|
Attachment #446949 -
Flags: superreview?(neil)
|
||
Updated•15 years ago
|
Attachment #446949 -
Flags: superreview?(neil) → superreview+
|
||
Comment 1•15 years ago
|
||
Comment on attachment 446949 [details] [diff] [review]
patch
Very nice, r=me with 1 nit:
>+ * @param aCanCreate [in] specifies if accessible can be created if it wasn't
"... if it didn't exist" please. :)
Attachment #446949 -
Flags: review?(marco.zehe) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
landed on 1.9.3 (Marco's comment is fixed) - http://hg.mozilla.org/mozilla-central/rev/6d27d066e685
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Attachment #446949 -
Flags: review?(bolterbugz)
You need to log in
before you can comment on or make changes to this bug.
Description
•