Closed Bug 567655 Opened 11 years ago Closed 11 years ago

Port Bug 519099 [Location bar stops working and does not allow any input. Restarts does not help] to SeaMonkey

Categories

(SeaMonkey :: Session Restore, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a2

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
From parent bug:

STEPS TO REPRODUCE
1. Make sure you have "Show my windows and tabs from last time" enabled
2. Go to http://www.chromeexperiments.com/detail/monster/
3. Click on "Launch Experiment"
4. Close the main window, leaving the popup as the only window open
5. Exit Firefox
6. Restart Firefox
7. It will not be possible to type anything in the Location bar

ADDITIONAL INFO
You wont be able to type anything into the Location bar now, restarting Firefox
wont help. Creating a new tab will not help either.

Only way to get out of this "locked" mode is to open a new window

Tested on Windows and could not reproduce, MAC OS X only?
Attachment #446963 - Flags: superreview?(neil)
Attachment #446963 - Flags: review?(neil)
Comment on attachment 446963 [details] [diff] [review]
patch

>       // make sure that at least the first window doesn't have anything hidden
>       if (this._initialState.windows[0])
>         delete this._initialState.windows[0].hidden;
>+      // Since nothing is hidden in the first window, it cannot be a popup
>+      delete this._initialState.windows[0].isPopup;
I don't know why the Firefox version of the file doesn't have the
if (this._initialState.windows[0])
check, but it makes no sense to have one line checked and one not checked.
Attached patch v2Splinter Review
I didn't found changeset, where it happen, lack of hg knowledge.
Attachment #446963 - Attachment is obsolete: true
Attachment #446966 - Flags: superreview?(neil)
Attachment #446966 - Flags: review?(neil)
Attachment #446963 - Flags: superreview?(neil)
Attachment #446963 - Flags: review?(neil)
Comment on attachment 446966 [details] [diff] [review]
v2

OK this version seems reasonable.
Attachment #446966 - Flags: superreview?(neil)
Attachment #446966 - Flags: superreview+
Attachment #446966 - Flags: review?(neil)
Attachment #446966 - Flags: review+
Pushed: http://hg.mozilla.org/comm-central/rev/0ba4ad058461
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
You need to log in before you can comment on or make changes to this bug.