Last Comment Bug 567655 - Port Bug 519099 [Location bar stops working and does not allow any input. Restarts does not help] to SeaMonkey
: Port Bug 519099 [Location bar stops working and does not allow any input. Res...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1a2
Assigned To: Misak Khachatryan
:
Mentors:
Depends on: 519099
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-23 09:12 PDT by Misak Khachatryan
Modified: 2010-05-23 11:31 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.01 KB, patch)
2010-05-23 09:12 PDT, Misak Khachatryan
no flags Details | Diff | Review
v2 (1.13 KB, patch)
2010-05-23 10:13 PDT, Misak Khachatryan
neil: review+
neil: superreview+
Details | Diff | Review

Description Misak Khachatryan 2010-05-23 09:12:58 PDT
Created attachment 446963 [details] [diff] [review]
patch

From parent bug:

STEPS TO REPRODUCE
1. Make sure you have "Show my windows and tabs from last time" enabled
2. Go to http://www.chromeexperiments.com/detail/monster/
3. Click on "Launch Experiment"
4. Close the main window, leaving the popup as the only window open
5. Exit Firefox
6. Restart Firefox
7. It will not be possible to type anything in the Location bar

ADDITIONAL INFO
You wont be able to type anything into the Location bar now, restarting Firefox
wont help. Creating a new tab will not help either.

Only way to get out of this "locked" mode is to open a new window

Tested on Windows and could not reproduce, MAC OS X only?
Comment 1 neil@parkwaycc.co.uk 2010-05-23 09:46:05 PDT
Comment on attachment 446963 [details] [diff] [review]
patch

>       // make sure that at least the first window doesn't have anything hidden
>       if (this._initialState.windows[0])
>         delete this._initialState.windows[0].hidden;
>+      // Since nothing is hidden in the first window, it cannot be a popup
>+      delete this._initialState.windows[0].isPopup;
I don't know why the Firefox version of the file doesn't have the
if (this._initialState.windows[0])
check, but it makes no sense to have one line checked and one not checked.
Comment 2 Misak Khachatryan 2010-05-23 10:13:54 PDT
Created attachment 446966 [details] [diff] [review]
v2

I didn't found changeset, where it happen, lack of hg knowledge.
Comment 3 neil@parkwaycc.co.uk 2010-05-23 11:13:32 PDT
Comment on attachment 446966 [details] [diff] [review]
v2

OK this version seems reasonable.
Comment 4 Misak Khachatryan 2010-05-23 11:31:47 PDT
Pushed: http://hg.mozilla.org/comm-central/rev/0ba4ad058461

Note You need to log in before you can comment on or make changes to this bug.