Closed Bug 567702 Opened 15 years ago Closed 15 years ago

opening file dialogs (and also print dialogs on Linux) doesn't work with integrated view manager hierarchy (bug 130078)

Categories

(Core :: Widget, defect)

Product:
Core
Component:
Widget
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(2 files, 1 obsolete file)

Part 2. Actually fix the problem.
1.13 KB, patch
roc
: review+
Details | Diff | Splinter Review
Part 1 v2. Factor out duplicated DOMWindowToWidget.
17.23 KB, patch
roc
: feedback+
Details | Diff | Splinter Review
For print preview the progress dialog comes up and nothing happens. For print it crashes.
roc already had a patch for print preview here http://hg.mozilla.org/users/rocallahan_mozilla.com/compositor-patches/file/ccef913ac074/fix-printpreview
OS: Linux → All
Hardware: x86_64 → All
I have a patch that fixes printing on Linux at least.
Summary: print/print preview doesn't work with integrated view manager hierarchy (bug 130078) → opening file dialogs (and also print dialogs on Linux) doesn't work with integrated view manager hierarchy (bug 130078)
We'll use another bug for print preview.
The function containing the problem, DOMWindowToWidget, is duplicated in two places (thanks to dholbert for adding that comment, I was able to fix another bug I didn't even know about). Let's factor it out and create a WidgetUtils class in part one.
Assignee: nobody → tnikkel
Attachment #451490 - Flags: review?(roc)
The actual fix is a one-liner. Walking the sametype parent chain of our docshell is not guaranteed to lead to a widget in the 130078 world, so just walk the parent chain.
Attachment #451492 - Flags: review?(roc)
Component: Layout → Widget
QA Contact: layout → general
Comment on attachment 451490 [details] [diff] [review] Part 1. Factor out duplicated DOMWindowToWidget. xpwidgets is a terrible name. Let's put WidgetUtils in widget/src/shared.
Attachment #451490 - Flags: review?(roc) → review+
Moved WidgetUtils to shared. Could you please have a look at my cargo-culting of makefiles?
Attachment #452438 - Flags: feedback?(roc)
Attachment #451490 - Attachment is obsolete: true
Comment on attachment 452438 [details] [diff] [review] Part 1 v2. Factor out duplicated DOMWindowToWidget. + -DUSE_TLS_FOR_TOOLKIT \ + -DNO_NSPR_10_SUPPORT=1 \ I don't think this should be needed +LOCAL_INCLUDES += \ + -I$(srcdir) \ + $(NULL) Nor this, surely?
Ok, those are gone. Anything else?
See comment 9.
Comment on attachment 452438 [details] [diff] [review] Part 1 v2. Factor out duplicated DOMWindowToWidget. +include $(topsrcdir)/ipc/chromium/chromium-config.mk Lose this too.
Attachment #452438 - Flags: feedback?(roc) → feedback+
http://hg.mozilla.org/mozilla-central/rev/99f7e3994a54 http://hg.mozilla.org/mozilla-central/rev/375eee52bbdd
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: