567706 - Try server emails are going to the hg changeset author and not the hg push source

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mats Palmgren (inactive)]

When I push to ssh://hg.mozilla.org/try/
I get some result emails to my hg account [e-mail]
and some to my ldap account [e-mail] for the same
changeset.  I'd like to get all emails to the same account please.
Either one is fine.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Dupe of bug 567478 ?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

If you could identify which emails to where it would be pretty helpful for that.

Comment 3

[Mats Palmgren (inactive)]

Bug 567478 seems to be about which of the two should get the emails.
I don't care as long as they are all sent to the same account.

Most of the emails goes to the patch author ([e-mail]), eg:
==========================
Your Try Server test (972cada69e71) was successfully completed on win32 on builder: WINNT 5.2 tryserver debug test mochitests-3/5.

It should be available for download at http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-972cada69e71

Summary of test results:
TinderboxSummaryMessage: s: try-w32-slave28
mochitest-plain-3: 5861/0/199
==========================

But some goes to the pusher account ([e-mail]), eg:
==========================
Your Try Server test (972cada69e71) was successfully completed on win32 on builder: WINNT 5.2 tryserver leak test build.

It should be available for download at http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-972cada69e71

Summary of test results:
TinderboxSummaryMessage: s: try-w32-slave19
check: 670/0
==========================

When I look at them now it appears the "build" mails goes to pusher,
while "test" emails goes to patch author.

Comment 4

[Mats Palmgren (inactive)]

When I think about it, it only makes sense to send mail to the pusher
account really.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I got some tryserver emails to my @helsinki.fi address, which is something
I have in the ssh key, and which I used originally when I got the cvs account.
But with hg I've always got the emails to my ldap account (@mozilla.com)

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Looks like we're providing different info to the MailNotifier for the build and packaged test.

The build gets a change from HgPoller, eg:
 All Changes
   1. Changed by: [e-mail]
      Changed at: Sun 23 May 2010 19:02:57
      Branch: try
      Revision: 4b78669e0ff7d3e54dbc29f2dabd16c291fac7d6
      Changed files:
          * toolkit/mozapps/update/updater/updater.cpp
      Comments:
      http://hg.mozilla.org/try/rev/4b78669e0ff7d3e54dbc29f2dabd16c291fac7d6
      Properties:

The author for that particular change is 'Shailen', while pushlog always returns the pusher and not the author (hence the Changed by).

During the build we set a 'who' property to 'Shaile' by executing  
  hg parent --template={author}
in the source dir. Note that the the template really needs a '\n' suffix so that we don't swallow the last character of the string. So it's (almost) the patch author, rather than the pusher.

If the build completes we do the sendchange to trigger the packaged unit test, setting user = %(who)s along the way:
 All Changes
  1.  Changed by: Shaile
      Changed at: Sun 23 May 2010 20:32:02
      Branch: tryserver-linux-opt-unittest
      Revision: 4b78669e0ff7
      Changed files:
          * http://stage.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/Shaile-4b78669e0ff7/tryserver-linux/firefox-3.7a5pre.en-US.linux-i686.tar.bz2
          * http://stage.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/Shaile-4b78669e0ff7/tryserver-linux/firefox-3.7a5pre.en-US.linux-i686.tests.zip
      Comments:
      Properties:
This is all the MailNotifier has to go on when it tries to report the result of the packaged test. Also note the directory the files are pushed to is 'Shaile-4b78669e0ff7' and not something philor based.

So I think we should
* figure out a way to get the pusher rather than the author when setting who property (from the original change ?)
* make sure that's used for the directory name and the sendchange for the tests
* end up delivering all emails to the pusher

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: WIP

This works in staging with pusher != author - emails sent to the pusher for a linux build and the packaged tests. Ben/Chris, in other places we use the build object there are try/except blocks, do we need something like that here ?

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Dupe of 567478 which will return the default emails back to the pusher, not the author of the changeset.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Re-opening this bug to only fix the email issue, and will change the summary of bug 567478 to be about fixing the urls and results output in the try emails.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

http://hg.mozilla.org/build/buildbotcustom/rev/7ef3fc54c56d

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Exception on log uploads

Seeing this on linux build and leak test build.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Cast the unicode string to a plain one

Landed this to fix the purple.
http://hg.mozilla.org/build/buildbotcustom/rev/05d86df18c9e