Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 567726 - Port Bug 561702 [sessionstore should not use RegExp static state] to SeaMonkey
: Port Bug 561702 [sessionstore should not use RegExp static state] to SeaMonkey
Product: SeaMonkey
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a2
Assigned To: Misak Khachatryan
Depends on: 561702
  Show dependency treegraph
Reported: 2010-05-24 02:12 PDT by Misak Khachatryan
Modified: 2010-05-24 03:16 PDT (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (2.45 KB, patch)
2010-05-24 02:12 PDT, Misak Khachatryan
neil: review+
neil: superreview+
Details | Diff | Splinter Review

Description Misak Khachatryan 2010-05-24 02:12:06 PDT
Created attachment 447057 [details] [diff] [review]

From parent bug:

RegExp.$* shouldn't be used. Its a non-standard JS api.
Comment 1 2010-05-24 02:51:57 PDT
Comment on attachment 447057 [details] [diff] [review]

>+      var match;
>+      if ((match = /^https?:\/\/(?:[^@\/\s]+@)?([\w.-]+)/.exec(aEntry.url)) != null) {
Write this as
var match = /^https?:\/\/(?:[^@\/\s]+@)?([\w.-]+)/.exec(aEntry.url);
if (match)
[The other two would be harder to rewrite so leave them as they are.]
Comment 2 Misak Khachatryan 2010-05-24 03:16:26 PDT
Fixed nit and pushed:

Note You need to log in before you can comment on or make changes to this bug.