Closed
Bug 567726
Opened 15 years ago
Closed 15 years ago
Port Bug 561702 [sessionstore should not use RegExp static state] to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a2
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file)
|
2.45 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
From parent bug:
RegExp.$* shouldn't be used. Its a non-standard JS api.
Attachment #447057 -
Flags: superreview?(neil)
Attachment #447057 -
Flags: review?(neil)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 447057 [details] [diff] [review]
patch
>+ var match;
>+ if ((match = /^https?:\/\/(?:[^@\/\s]+@)?([\w.-]+)/.exec(aEntry.url)) != null) {
Write this as
var match = /^https?:\/\/(?:[^@\/\s]+@)?([\w.-]+)/.exec(aEntry.url);
if (match)
[The other two would be harder to rewrite so leave them as they are.]
Attachment #447057 -
Flags: superreview?(neil)
Attachment #447057 -
Flags: superreview+
Attachment #447057 -
Flags: review?(neil)
Attachment #447057 -
Flags: review+
|
Assignee | |
Comment 2•15 years ago
|
||
Fixed nit and pushed: http://hg.mozilla.org/comm-central/rev/23551ff0a6af
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
You need to log in
before you can comment on or make changes to this bug.
Description
•