Closed
Bug 567771
Opened 15 years ago
Closed 15 years ago
When changing aero theme to any persona text becomes bright
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta1+ |
People
(Reporter: icecold, Assigned: robarnold)
References
Details
(Keywords: regression)
Attachments
(3 files)
115.09 KB,
image/jpeg
|
Details | |
718 bytes,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
774 bytes,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100524 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100524 Minefield/3.7a5pre
When I wanted to use a persona theme instead of aero text became bright. I fixes this by restarting browser.
Reproducible: Always
Steps to Reproduce:
1.Use aero theme (default) that re-landed in 20100524 build.
2.Chose any persona in add-ons manager.
3.And text becomes bright.
Actual Results:
Text became bright on tabs and menu bar.
Expected Results:
Everything should be fine.
Disabled Direct2D.
Reporter | ||
Comment 1•15 years ago
|
||
Updated•15 years ago
|
Component: Theme → Widget: Win32
Product: Firefox → Core
QA Contact: theme → win32
Updated•15 years ago
|
Assignee | ||
Comment 2•15 years ago
|
||
nsWindow::UpdateGlass was using the old margins. Whoops!
Reporter | ||
Comment 3•15 years ago
|
||
For me it's fixed in build 20100525.
Updated•15 years ago
|
Attachment #447184 -
Flags: review?(jmathies) → review+
Comment 4•15 years ago
|
||
This bug still exists, I know it looks like it was gone.. but that is what I noticed too, but I just saw it again.. with D2D/DW off, no persona in addon manager, and went to getpersonas.com to wear lwtheme and just mousing over previews, I see this bug.
Comment 5•15 years ago
|
||
This should block the beta, since it will hurt glass dogfooding
blocking2.0: --- → beta1+
Keywords: checkin-needed
Reporter | ||
Comment 6•15 years ago
|
||
Dale you're right. Just checked it and it's still present. Bug 554874 should also block beta. Browser is unusable with Direct2D and aero together.
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
No longer depends on: 513170
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
There is also another symptom within this bug, when I follow the steps to reproduct it, if the window is maximized, after change personas, besides the text become blur, the window is resized a little bit, even though it is not obvious but the icon in upper-right corner changed from 'Restore' to 'Maximize', means the window is not maximized anymore.
This is also only on Win 7.
Please note that with the new build 20100527, text blur is resolved but the window resize still exist.
This happened for theme change both default(aero)->personas and personas->default(aero). Personas->Persons works fine.
Assignee | ||
Comment 10•15 years ago
|
||
(In reply to comment #9)
> Please note that with the new build 20100527, text blur is resolved but the
> window resize still exist.
>
> This happened for theme change both default(aero)->personas and
> personas->default(aero). Personas->Persons works fine.
Filed bug 568490 on it.
Comment 11•15 years ago
|
||
Comment on attachment 447184 [details] [diff] [review]
Clear the glass region when transitioning from glass window
>+ if (mTransparencyMode == eTransparencyGlass)
>+ memset(&mGlassMargins, 0, sizeof mGlassMargins);
Was this meant to be +#if MOZ_WINSDK_TARGETVER >= MOZ_NTDDI_LONGHORN
(all other references to mGlassMargins are)
Assignee | ||
Comment 12•15 years ago
|
||
(In reply to comment #11)
> (From update of attachment 447184 [details] [diff] [review])
> >+ if (mTransparencyMode == eTransparencyGlass)
> >+ memset(&mGlassMargins, 0, sizeof mGlassMargins);
> Was this meant to be +#if MOZ_WINSDK_TARGETVER >= MOZ_NTDDI_LONGHORN
> (all other references to mGlassMargins are)
Yep! I forgot we supported multiple SDKs, thanks for noticing!
Attachment #448006 -
Flags: review?(jmathies)
Comment 14•15 years ago
|
||
Comment on attachment 448006 [details] [diff] [review]
Wrap the previous patch in an SDK guard block
>+#if MOZ_WINSDK_TARGETVER >= MOZ_NTDDI_LONGHORN
> if (mTransparencyMode == eTransparencyGlass)
> memset(&mGlassMargins, 0, sizeof mGlassMargins);
>+#endif
Note: the other places where this #if is used all have
#endif // #if MOZ_WINSDK_TARGETVER >= MOZ_NTDDI_LONGHORN
Attachment #448006 -
Flags: review?(jmathies) → review+
Comment 15•15 years ago
|
||
Comment on attachment 448006 [details] [diff] [review]
Wrap the previous patch in an SDK guard block
Pushed changeset 7af2e4e00f86 to mozilla-central.
You need to log in
before you can comment on or make changes to this bug.
Description
•