567868 - nsStackWalk.cpp(1019) : warning C4244: '=' : conversion from 'DWORD64' to 'PRUptrdiff', possible loss of data

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

Filing this bug on this warning:
{
> xpcom/base/nsStackWalk.cpp(1019) : warning C4244: '=' : conversion from 'DWORD64' to 'PRUptrdiff', possible loss of data
> xpcom/base/nsStackWalk.cpp(1071) : warning C4244: '=' : conversion from 'DWORD64' to 'PRUptrdiff', possible loss of data
}

I'm pretty sure this is on x86, so PRUptrdiff is 32-bit.  (hence the loss of data -- we're stuffing a 64-bit value into a 32-bit value)

This warning appears happens in both opt & debug build logs.  I don't see any clobber m-c builds on tinderbox right now, but here are two tryserver builds that show the warning:

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1274723480.1274735946.30601.gz
WINNT 5.2 tryserver build on 2010/05/24 10:51:20

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1274727093.1274737015.3023.gz
WINNT 5.2 tryserver leak test build on 2010/05/24 11:51:33

Comment 1

[:Cykesiopka]

Assuming I haven't screwed up, the lines in question both started with "ok = _Sym".

These lines were removed in Bug 699247.

Comment 2

[Daniel Holbert [:dholbert]]

I'd believe it; I don't recall seeing these warnings recently.

(a local "hg up --date 2010-05-25" tells me you're right RE which lines that the warnings pointed to.)

Thanks for the bug-cleanup!