567937 - bustage on x64 build due to jsnativestack.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Makoto Kato [:m_kato]]

This is a regression of bug 237006.

cl -Fojsnativestack.obj -c   -DOSTYPE=\"WINNT6.0\" -DOSARCH=WINNT -DEXPORT_JS_API  -DJS_HAS_CTYPES -Ictypes/libffi/include -I.  -I/c/Workspace/hg.mozilla.org/mozilla-win64/js/src -I. -I./../../dist/include -I./../../dist/include/nsprpub  -Ic:/Workspace/hg.mozilla.org/objdir-win64-vc10/dist/include/nspr   -I/c/Workspace/hg.mozilla.org/mozilla-win64/js/src    -GR- -TP -nologo -wd4345 -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800  -DDEBUG -D_DEBUG -DDEBUG_makoto -DTRACING -Zi -O2 -GL -MDd           -FI ./js-confdefs.h -DMOZILLA_CLIENT /c/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp
jsnativestack.cpp
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(123) : error C4235: nonstandard extension used : '__asm' keyword not supported on this architecture
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(124) : error C2065: 'MOV' : undeclared identifier
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(124) : error C2146: syntax error : missing ';' before identifier 'EAX'
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(124) : error C2065: 'EAX' : undeclared identifier
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(124) : error C2065: 'FS' : undeclared identifier
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(124) : error C2143: syntax error : missing ';' before ':'
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(124) : error C2143: syntax error : missing ';' before ':'
c:/Workspace/hg.mozilla.org/mozilla-win64/js/src/jsnativestack.cpp(124) : error C2059: syntax error : 'bad suffix on number'


_WIN32 is generic macro for Windows x86 and Windows x64.  We should use _M_IX86 for x86 cpu.  (For x64, we should use _M_X64 or _M_AMD64)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: [checked in] patch

Comment 2

[Armen [:armenzg]]

I have hit this today as I was trying to automate the Windows 64 bit builds.
I will currently have the builds red until this lands.

Increasing severity as it blocks the Win64 bit builds work.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 447256 [details] [diff] [review]
[checked in] patch

Stealing review, please yell if this is not okay.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 447256 [details] [diff] [review]
[checked in] patch

I landed this in mozilla-central: changeset:   42822:82be6abe2a53

Comment 5

[Armen [:armenzg]]

From my last build this has been fixed.
Thanks guys!