Closed Bug 568015 Opened 15 years ago Closed 15 years ago

[k] Remove forums.css from common bundle and create a forums bundle for it.

Categories

(support.mozilla.org :: Knowledge Base Software, task, P2)

Product:
support.mozilla.org
Component:
Knowledge Base Software
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rrosario, Assigned: rrosario)

Details

(Whiteboard: [QA-])

Right now forums.css is in the common bundle and the questions templates are pulling it in unnecessarily.
We should come up with a guideline for the number of bundles any page is allowed to use: I think if we go much above 2 the extra HTTP request round trip will start to overwhelm the benefit of pulling less CSS (especially when it's all gzipped via Zeus).
Priority: -- → P2
Target Milestone: 2.1 → 2.2
Yes, I agree. In general it should probably just be 2: common bundle + app bundle. The common should be cached after the first hit anyway, right? The alternative is to just have one bundle and namespace (body.forums #whatever) where necessary. Either way this is just a one time empty cache hit.
Let's go with common bundle + app.
Fix landed in questions branch: http://github.com/jsocol/kitsune/commit/90446f40dca1171db829ce06067fede057185d0f
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.