Closed Bug 568027 Opened 15 years ago Closed 14 years ago

TEST-UNEXPECTED-FAIL | test_plugins.js | 2 == 8 | with build in homedir

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: zwol, Assigned: ginnchen+exoracle)

References

Details

(Whiteboard: [AOMTestday])

Attachments

(1 file)

This is a follow-up to bug 562886. After the fix there, the test still fails for my local builds, but with a slightly different syndrome: TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 37] true == true TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 44] {b309a348-ace6-4a6e-909a-31251dc04ce3} != null TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 47] [object Object] != null TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 48] Test Plug-in == Test Plug-in TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 49] Plug-in for testing purposes. == Plug-in for testing purposes. TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 50] == TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 51] 1.0.0.0 == 1.0.0.0 TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 52] plugin == plugin TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 53] false == false TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 54] false == false TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 55] true == true TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 56] true == true TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 57] true == true TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 58] 0 == 0 TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 59] 4 == 4 TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [anonymous : 60] 0 == 0 TEST-PASS | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | [get_unix_test_plugin : 24] true == true TEST-UNEXPECTED-FAIL | /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js | 2 == 8 - See following stack: JS frame :: /home/zack/src/mozilla/moz-central/testing/xpcshell/head.js :: do_throw :: line 257 JS frame :: /home/zack/src/mozilla/moz-central/testing/xpcshell/head.js :: do_check_eq :: line 287 JS frame :: /home/zack/src/mozilla/obj-mozcentral/_tests/xpcshell/test_extensionmanager/xpcshell/test_plugins.js :: anonymous :: line 69 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/AddonManager.jsm :: safeCall :: line 41 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/AddonManager.jsm :: anonymous :: line 565 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/PluginProvider.jsm :: PL_getAddon :: line 50 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/AddonManager.jsm :: callProvider :: line 69 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/AddonManager.jsm :: anonymous :: line 563 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/AddonManager.jsm :: AOC_callNext :: line 116 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/AddonManager.jsm :: anonymous :: line 567 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/XPIProvider.jsm :: anonymous :: line 1718 JS frame :: file:///home/zack/src/mozilla/obj-mozcentral/dist/bin/modules/XPIProvider.jsm :: anonymous :: line 2891 TEST-INFO | (xpcshell/head.js) | exiting test *** WARN addons.manager: Exception calling callback: 2147500036 *** LOG addons.xpi: shutdown WARNING: nsExceptionService ignoring thread destruction after shutdown: file /home/zack/src/mozilla/moz-central/xpcom/base/nsExceptionService.cpp, line 197 nsXPConnect::CommenceShutdown() nsStringStats => mAllocCount: 3631 => mReallocCount: 320 => mFreeCount: 3631 => mShareCount: 8683 => mAdoptCount: 988 => mAdoptFreeCount: 988 <<<<<<< This is an objdir build in my home directory on x86-64 Linux. Dave Townsend said in bug 562886: > Ah nice, you're building in your home directory so the manager things > it is a user installed plugin. Need some tweaking to solve that...
To be clear, this happens only for me locally, not on the try server.
We try to guess whether a plugin is system-installed, app-installed or user installed based on the following: If the plugin file is inside the app/plugins directory then it is app installed. If the plugin file is inside the profile directory then it is profile installed If the plugin file is somewhere under the user's home directory then it is user installed. Otherwise it is system installed. This logic is basically sound I think, however in the case of the test the plugin appears in different places depending on where the objdir is. We can probably just do similarly to bug 562886 to fix this in the test.
Attached patch patchSplinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #452241 - Flags: review?(dtownsend)
Comment on attachment 452241 [details] [diff] [review] patch I guess this works. Get rid of the redundant pluginScope variable now though.
Attachment #452241 - Flags: review?(dtownsend) → review+
Could you also add references to this and bug 562886 in the comment there.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Marking as verified fixed based on no failures in the last months.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [AOMTestday]
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: