Closed
Bug 568051
Opened 15 years ago
Closed 15 years ago
TM: stringify property ids for scripted proxies
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
Attachments
(1 file, 1 obsolete file)
|
12.77 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
The latest version of the proxy spec requires this.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #447347 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Attachment #447354 -
Flags: review?(mrbkap)
|
|
Assignee | |
Updated•15 years ago
|
Blocks: harmony:proxies
|
||
Comment 3•15 years ago
|
||
Comment on attachment 447354 [details] [diff] [review]
patch
>+ AutoValueRooter tvr(cx);
>+ if (!TryHandlerTrap(cx, proxy, Trap(cx, JSVAL_TO_OBJECT(handler), ATOM(getOwnPropertyNames),
>+ 0, NULL, tvr.addr())))
> return false;
Nit: multiline condition wants braces around the consequent.
Attachment #447354 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
I will push the patch without fixing the nit. I have a reviewed follow-up patch that removes the badly formatted code and fixes the nit.
|
||
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•