568180 - unhiding key protected channels shouldn't cause a key prompt to appear

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Svetlana Tkachenko]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 XPCOMViewer/0.9.2
Build Identifier: ChatZilla 0.9.86-2010031920; Firefox 3.6.3, 3.6.4rc, 3.7.a5pre (all of them)

The redundant key prompt appears.

Reproducible: Always

Steps to Reproduce:
1.open ChatZilla 
2./server moznet 
3./j #chan 
4./mode +k test 
5.midddle-click the #chan tab to hide it 
6.In the menu, go to IRC - Views - #chan to unhide it
Actual Results:  
The "Enter key for url irc://moznet/chan,needkey:" prompt pops up.
Whatever you put or hit Cancel, the channel opens anyway.

Expected Results:  
The channel should have opened without the prompt for the key.

Comment 1

[David Vo [:auscompgeek]]

I can confirm this in Minefield as XULRunner. (firefox -app ...)

Comment 2

[Justin Wood (:Callek)]

Gryllida wishes this assigned to him, I'm not about to mark as confirmed based on an XULRunner-based test though.

Comment 3

[Svetlana Tkachenko]

Attachment: fix

Comment 4

[James Ross]

Comment on attachment 679879 [details] [diff] [review]
fix

Review of attachment 679879 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: xul/content/static.js
@@ +2035,3 @@
>              }
>  
> +            if (url.needkey && chan.joined == false)

Nit: if (url.needkey && !chan.joined)

@@ +2036,5 @@
>  
> +            if (url.needkey && chan.joined == false)
> +            {
> +                if (url.key)
> +                   key = url.key;

Nit: missing 1 space of indentation here.

Comment 5

[James Ross]

http://hg.mozilla.org/chatzilla/rev/1c934e4a6978