568181 - Port bug 566910 'copy password' context menu item for password manager

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[[e-mail]]

We share the JS backend code so we only need to copy the context menu popup.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 3]

The strings are in Toolkit, too, as is the test. Made the change from http://hg.mozilla.org/mozilla-central/rev/0eed88315d8e in addition to http://hg.mozilla.org/mozilla-central/rev/d57d62799e35.

Comment 2

[[e-mail]]

Comment on attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

>+               onpopupshowing="UpdateCopyPassword()">
Nit: JS statements end in semicolons.

>+                oncommand="CopyPassword()"/>
Ditto. Please fix these two before checkin.

>-              onselect="SignonSelected();">
>+              onselect="SignonSelected();"
>+              context="signonsTreeContextMenu">
[I don't mind so much keeping in sync with toolkit here, I just wanted to point out but they could have saved a delete by inserting instead of appending.]

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

http://hg.mozilla.org/comm-central/rev/7a4c37247aa5