Last Comment Bug 568181 - Port bug 566910 'copy password' context menu item for password manager
: Port bug 566910 'copy password' context menu item for password manager
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.1a3
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on: 568287
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-26 03:58 PDT by neil@parkwaycc.co.uk
Modified: 2010-07-18 11:10 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch [Checkin: comment 3] (2.05 KB, patch)
2010-07-02 23:06 PDT, Jens Hatlak (:InvisibleSmiley)
neil: review+
neil: superreview+
Details | Diff | Review

Description neil@parkwaycc.co.uk 2010-05-26 03:58:33 PDT
We share the JS backend code so we only need to copy the context menu popup.
Comment 1 Jens Hatlak (:InvisibleSmiley) 2010-07-02 23:06:42 PDT
Created attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

The strings are in Toolkit, too, as is the test. Made the change from http://hg.mozilla.org/mozilla-central/rev/0eed88315d8e in addition to http://hg.mozilla.org/mozilla-central/rev/d57d62799e35.
Comment 2 neil@parkwaycc.co.uk 2010-07-03 16:43:42 PDT
Comment on attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

>+               onpopupshowing="UpdateCopyPassword()">
Nit: JS statements end in semicolons.

>+                oncommand="CopyPassword()"/>
Ditto. Please fix these two before checkin.

>-              onselect="SignonSelected();">
>+              onselect="SignonSelected();"
>+              context="signonsTreeContextMenu">
[I don't mind so much keeping in sync with toolkit here, I just wanted to point out but they could have saved a delete by inserting instead of appending.]
Comment 3 Jens Hatlak (:InvisibleSmiley) 2010-07-18 11:09:37 PDT
Comment on attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

http://hg.mozilla.org/comm-central/rev/7a4c37247aa5

Note You need to log in before you can comment on or make changes to this bug.