The default bug view has changed. See this FAQ.

Port bug 566910 'copy password' context menu item for password manager

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
UI Design
--
enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1a3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
We share the JS backend code so we only need to copy the context menu popup.
Depends on: 568287
No longer depends on: 566910
(Assignee)

Updated

7 years ago
Assignee: nobody → jh
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
Created attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

The strings are in Toolkit, too, as is the test. Made the change from http://hg.mozilla.org/mozilla-central/rev/0eed88315d8e in addition to http://hg.mozilla.org/mozilla-central/rev/d57d62799e35.
Attachment #455828 - Flags: superreview?(neil)
Attachment #455828 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
Keywords: helpwanted
(Reporter)

Comment 2

7 years ago
Comment on attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

>+               onpopupshowing="UpdateCopyPassword()">
Nit: JS statements end in semicolons.

>+                oncommand="CopyPassword()"/>
Ditto. Please fix these two before checkin.

>-              onselect="SignonSelected();">
>+              onselect="SignonSelected();"
>+              context="signonsTreeContextMenu">
[I don't mind so much keeping in sync with toolkit here, I just wanted to point out but they could have saved a delete by inserting instead of appending.]
Attachment #455828 - Flags: superreview?(neil)
Attachment #455828 - Flags: superreview+
Attachment #455828 - Flags: review?(neil)
Attachment #455828 - Flags: review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 455828 [details] [diff] [review]
patch [Checkin: comment 3]

http://hg.mozilla.org/comm-central/rev/7a4c37247aa5
Attachment #455828 - Attachment description: patch → patch [Checkin: comment 3]
(Assignee)

Updated

7 years ago
Severity: normal → enhancement
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
You need to log in before you can comment on or make changes to this bug.