Closed
Bug 568337
Opened 15 years ago
Closed 15 years ago
MathUtils::doubleToBool should be inlined in LIR
Categories
(Tamarin Graveyard :: Virtual Machine, enhancement, P2)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
DUPLICATE
of bug 477779
Q3 11 - Serrano
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
edwsmith
:
review-
|
Details | Diff | Splinter Review |
The primes.as benchmark spends 12% of its time in this function, much of which is call overhead. It could be trivially inlined using existing LIR.
|
Assignee | |
Comment 1•15 years ago
|
||
Speeds up prime.as by ~5% on my MacTel32.
Assignee: nobody → stejohns
Attachment #447611 -
Flags: review?(edwsmith)
|
||
Comment 2•15 years ago
|
||
This is a dup of bug 477779, want poach it from me? Turns doubleToBool() into a single instruction on supported CPU's. Code for x86, x64, and PPC is already done. could use your code on the rest, or finish the other backends.
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 447611 [details] [diff] [review]
Patch
doubleToBool is dead code after this patch, should delete it.
plus, see above -- if you dont want to poach bug 4777779 then we can do this one in the interim.
due diligence:
code size #s?
results on other tests?
Attachment #447611 -
Flags: review?(edwsmith) → review-
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.2
|
|
Assignee | |
Comment 4•15 years ago
|
||
Doh -- hadn't realized this is a dupe. I like the other approach better, I'll just close this one out.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•