568375 - SpiderMonkey never generates JSOP_XMLOBJECT bytecode

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: Patch demonstrating that JSOP_XMLOBJECT is never used.

SpiderMonkey supports, but never generates, the JSOP_XMLOBJECT bytecode.  By inspection of the code, there doesn't seem to be anything that generates JSOP_XMLOBJECT, and the attached patch, which adds 'JS_ASSERT(0)' calls to each point in the code that processes JSOP_XMLOBJECT bytecodes, causes no regressions.

The bytecode should be deleted.

Comment 1

[Brendan Eich [:brendan]]

See the comment atop jsopcode.tbl for how to "remove" an op -- thanks for catching this one.

/be

Comment 2

[Jim Blandy :jimb]

Attachment: Delete the JSOP_XMLOBJECT bytecode.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 450252 [details] [diff] [review]
Delete the JSOP_XMLOBJECT bytecode.

You also need to bump the bytecode version (see jsxdrapi.h, search for c0d3 I think), in case someone had ancient serialized code that used the opcode; r=me with that as well.

Comment 4

[Jim Blandy :jimb]

http://hg.mozilla.org/tracemonkey/rev/9006396fcf1f

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/9006396fcf1f