SpiderMonkey never generates JSOP_XMLOBJECT bytecode

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(2 attachments)

(Assignee)

Description

9 years ago
Created attachment 447648 [details] [diff] [review]
Patch demonstrating that JSOP_XMLOBJECT is never used.

SpiderMonkey supports, but never generates, the JSOP_XMLOBJECT bytecode.  By inspection of the code, there doesn't seem to be anything that generates JSOP_XMLOBJECT, and the attached patch, which adds 'JS_ASSERT(0)' calls to each point in the code that processes JSOP_XMLOBJECT bytecodes, causes no regressions.

The bytecode should be deleted.
See the comment atop jsopcode.tbl for how to "remove" an op -- thanks for catching this one.

/be
(Assignee)

Updated

9 years ago
Assignee: general → jim
(Assignee)

Comment 2

9 years ago
Created attachment 450252 [details] [diff] [review]
Delete the JSOP_XMLOBJECT bytecode.
Attachment #450252 - Flags: review?(jwalden+bmo)
Comment on attachment 450252 [details] [diff] [review]
Delete the JSOP_XMLOBJECT bytecode.

You also need to bump the bytecode version (see jsxdrapi.h, search for c0d3 I think), in case someone had ancient serialized code that used the opcode; r=me with that as well.
Attachment #450252 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/tracemonkey/rev/9006396fcf1f
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-tracemonkey]

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/9006396fcf1f
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.