Closed
Bug 568429
Opened 14 years ago
Closed 14 years ago
findbar widget should use mozIsTextField
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla2.0b1
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
... rather than checking .type manually and ignoring "search" or "tel": http://hg.mozilla.org/mozilla-central/annotate/28aa6a46c28c/toolkit/content/widgets/findbar.xml#l1353
|
||
Updated•14 years ago
|
Assignee: nobody → mano
Status: NEW → ASSIGNED
|
Assignee | |
Comment 1•14 years ago
|
||
Stealing this, hope you don't mind! I moved the input check before the mimeTypeIsTextBased one, since I figured it's the more common case. This loses the check for file inputs, but that doesn't matter since their text fields are not focusable.
Assignee: mano → gavin.sharp
Attachment #451296 -
Flags: review?(mano)
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 451296 [details] [diff] [review] patch Thanks... r=mano.
Attachment #451296 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c2bcd4953d56
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
|
|
Assignee | |
Updated•14 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•