568476 - [e10s-fennec] crash [@ nsGlobalWindow::SaveWindowState]

Status: RESOLVED WONTFIX

(Core :: IPC, defect, P3)

Description

[Oleg Romashin (:romaxa)]

xulrunner e10s 43217:dc9cc3820b02
fennec-e10s 1643:88f97721f8bb
Qt port

resize fennec to small screen 800x480
load about:license URL

when page is visible, type url bar and load another URL "about:buildconfig"

result:
Fennec crashes in nsGlobalWindow::SaveWindowState, because inner == NULL.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Child crash backtrace

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: parent process crashed after child process crash

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

For the content process crash a simple null check should be ok.

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Null check.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 449192 [details] [diff] [review]
Null check.

Remove the useless assertion
NS_ASSERTION(inner, "No inner window to save");

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: to checking, NULL check no, assertion..

Comment 7

[Boris Zbarsky [:bzbarsky]]

Wait.  So how are we ending up with a null inner here, exactly?

Comment 8

[Oleg Romashin (:romaxa)]

(In reply to comment #7)
> Wait.  So how are we ending up with a null inner here, exactly?

Yes, null inner

Comment 9

[Boris Zbarsky [:bzbarsky]]

I understand that, but WHY?  That shouldn't happen; that's why the assertion is there.  Why is it happening?  Who screwed up and how?

Comment 10

[Oleg Romashin (:romaxa)]

I started after previous merge with m-c...
I had the same question, but did not get what is going on...
there is backtrace + debug log in attachment

Comment 11

[Boris Zbarsky [:bzbarsky]]

OK.  So the docshell has an mContentViewer and an mOSHE but its window has no inner?  That's just broken beyond belief.  The inner is clearly non-null when the previous page is loaded.  Care to set a watchpoint in the debugger and tell me when it becomes null?

Comment 12

[Josh Matthews [:jdm]]

I'm going to clear checkin-needed since there are unanswered questions remaining.

Comment 13

[Jeremias Bosch (:jbos)]

seems not needed anymore, remove dep

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.