Closed Bug 568476 Opened 10 years ago Closed 1 year ago

[e10s-fennec] crash [@ nsGlobalWindow::SaveWindowState]

Categories

(Core :: IPC, defect, P3, critical)

x86
Linux
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
e10s - ---

People

(Reporter: romaxa, Assigned: romaxa)

Details

(Keywords: crash)

Crash Data

Attachments

(4 files)

xulrunner e10s 43217:dc9cc3820b02
fennec-e10s 1643:88f97721f8bb
Qt port

resize fennec to small screen 800x480
load about:license URL

when page is visible, type url bar and load another URL "about:buildconfig"

result:
Fennec crashes in nsGlobalWindow::SaveWindowState, because inner == NULL.
Attached file Child crash backtrace
Severity: normal → critical
Keywords: crash
Summary: [e10s-fennec] crash nsGlobalWindow::SaveWindowState → [e10s-fennec] crash [@ nsGlobalWindow::SaveWindowState]
For the content process crash a simple null check should be ok.
Attached patch Null check.Splinter Review
Attachment #449192 - Flags: review?(Olli.Pettay)
Comment on attachment 449192 [details] [diff] [review]
Null check.

Remove the useless assertion
NS_ASSERTION(inner, "No inner window to save");
Attachment #449192 - Flags: review?(Olli.Pettay) → review+
Attachment #449798 - Attachment description: NULL check no, assertion.. → to checking, NULL check no, assertion..
Keywords: checkin-needed
Wait.  So how are we ending up with a null inner here, exactly?
Assignee: nobody → romaxa
(In reply to comment #7)
> Wait.  So how are we ending up with a null inner here, exactly?

Yes, null inner
I understand that, but WHY?  That shouldn't happen; that's why the assertion is there.  Why is it happening?  Who screwed up and how?
I started after previous merge with m-c...
I had the same question, but did not get what is going on...
there is backtrace + debug log in attachment
OK.  So the docshell has an mContentViewer and an mOSHE but its window has no inner?  That's just broken beyond belief.  The inner is clearly non-null when the previous page is loaded.  Care to set a watchpoint in the debugger and tell me when it becomes null?
I'm going to clear checkin-needed since there are unanswered questions remaining.
Keywords: checkin-needed
Blocks: 583135
seems not needed anymore, remove dep
No longer blocks: 583135
Crash Signature: [@ nsGlobalWindow::SaveWindowState]
Priority: -- → P3
Closing because no crash reported since 12 weeks.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.