568509 - mark element should not report as an HTMLSpanElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks, but could you keep the todo?

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

This patch is using content/html/content/test/test_bug389797.html instead of content/html/content/test/test_bug485377.html

Ms2ger: for the todos, there is one fixed with the patch. The second one (HTMLUnknownElement) isn't specific to <mark> so I don't think we should focus on that.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #2)
> Ms2ger: for the todos, there is one fixed with the patch. The second one
> (HTMLUnknownElement) isn't specific to <mark> so I don't think we should focus
> on that.

Sure, how about testing it for all elements in test_bug389797.html then?

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to comment #3)
> (In reply to comment #2)
> > Ms2ger: for the todos, there is one fixed with the patch. The second one
> > (HTMLUnknownElement) isn't specific to <mark> so I don't think we should focus
> > on that.
> 
> Sure, how about testing it for all elements in test_bug389797.html then?

Is that a parser or content bug ? Maybe we should open a bug (if there isn't already one) and see what do to in the bug. I don't think it would be a good idea to add the todo_ with this bug.

Comment 5

[Mounir Lamouri (:mounir)]

Blockers are fixed, let's mark it checkin-needed.

Comment 6

[Mounir Lamouri (:mounir)]

The most important part of this patch has been landed with bug 485377, so I'm marking it as FIXED and I will open another bug for the test deletion.

Comment 7

[Mounir Lamouri (:mounir)]

(In reply to comment #6)
> The most important part of this patch has been landed with bug 485377, so I'm
> marking it as FIXED and I will open another bug for the test deletion.

Actually, the test hasn't been added by bug 485377 so, everything's allright.